Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20542] Adapt nightly jobs for all supported versions #4549

Merged
merged 7 commits into from
Mar 14, 2024
Merged

[20542] Adapt nightly jobs for all supported versions #4549

merged 7 commits into from
Mar 14, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Mar 12, 2024 •
edited by EduPonz
Loading

Description

This PR removes the versioning in the .repos workflow configuration files to let each version contain its proper .repos file.
This PR would be cherry picked in the supported versions.

Related PRs:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added the skip-ci Automatically pass CI label Mar 12, 2024
@JesusPoderoso JesusPoderoso added this to the v2.14.1 milestone Mar 12, 2024
EduPonz
EduPonz suggested changes Mar 12, 2024
View reviewed changes
.github/workflows/config/ci_colcon.meta Outdated Show resolved Hide resolved
.github/workflows/reusable-mac-ci.yml Outdated Show resolved Hide resolved
EduPonz
EduPonz suggested changes Mar 12, 2024
View reviewed changes
.github/workflows/reusable-mac-ci.yml Outdated Show resolved Hide resolved
EduPonz
EduPonz previously approved these changes Mar 12, 2024
View reviewed changes
@EduPonz
Copy link

EduPonz commented Mar 12, 2024

@JesusPoderoso I think we need to run CI here

@JesusPoderoso JesusPoderoso added no-test Skip CI tests if PR marked with this label and removed skip-ci Automatically pass CI labels Mar 12, 2024
@JesusPoderoso JesusPoderoso reopened this Mar 12, 2024
@JesusPoderoso JesusPoderoso force-pushed the hotfix/fix_nightly_jobs branch from 3e2da6d to d2e63c0 Compare March 12, 2024 15:47
@JesusPoderoso JesusPoderoso added ci-pending PR which CI is running ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed no-test Skip CI tests if PR marked with this label ci-pending PR which CI is running labels Mar 12, 2024
EduPonz added a commit that referenced this pull request Mar 13, 2024
@EduPonz
Refs #20542: Manual cherry-pick of PR #4549
8a47ccb 
Signed-off-by: EduPonz <[email protected]>
EduPonz added a commit that referenced this pull request Mar 13, 2024
@EduPonz
Refs #20542: Manual cherry-pick of PR #4549
1488198 
Signed-off-by: EduPonz <[email protected]>
@EduPonz EduPonz mentioned this pull request Mar 13, 2024
Merged
6 tasks
EduPonz added a commit that referenced this pull request Mar 13, 2024
@EduPonz
Refs #20542: Manual cherry-pick of PR #4549
62f7af2 
Signed-off-by: EduPonz <[email protected]>
EduPonz added a commit that referenced this pull request Mar 13, 2024
@EduPonz
Refs #20542: Manual cherry-pick of PR #4549
9480c9e 
Signed-off-by: EduPonz <[email protected]>
EduPonz added a commit that referenced this pull request Mar 13, 2024
@EduPonz
Refs #20542: Manual cherry-pick of PR #4549
51cac8e 
Signed-off-by: EduPonz <[email protected]>
JesusPoderoso and others added 7 commits March 13, 2024 17:00
@JesusPoderoso @EduPonz
Refs #20542: Adapt nightly jobs for all supported versions
3c4dadb 
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
@JesusPoderoso @EduPonz
Refs #20542: Simplify workflows
60d1f7e 
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
@JesusPoderoso @EduPonz
Refs #20542: Update json metas to yaml
036ab6b 
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
@JesusPoderoso @EduPonz
Refs #20542: Apply rev suggestions
93d836a 
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
@JesusPoderoso @EduPonz
Refs #20542: Address missing suggestion
2382a57 
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
@JesusPoderoso @EduPonz
Refs #20542: Apply rev suggestions (2)
4e5d1a2 
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
@EduPonz
Refs #20542: Remove coverage.repos file
594f101 
Signed-off-by: EduPonz <[email protected]>
@EduPonz EduPonz force-pushed the hotfix/fix_nightly_jobs branch from d2e63c0 to 594f101 Compare March 13, 2024 16:04
JesusPoderoso
JesusPoderoso commented Mar 13, 2024
View reviewed changes
Copy link
Contributor Author

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

MiguelCompany pushed a commit that referenced this pull request Mar 14, 2024
@EduPonz
Manual cherry-pick of PR #4549 (#4556)
f6d8c14 
* Refs #20542: Manual cherry-pick of PR #4549

Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Add missing ci.meta

Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Fix metas as yml

Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Fix paths to .metas

Signed-off-by: EduPonz <[email protected]>

---------

Signed-off-by: EduPonz <[email protected]>
EduPonz added a commit that referenced this pull request Mar 14, 2024
@JesusPoderoso @EduPonz
Fix CI version management (#4484)
75d6958 
* Refs #20542: Fix CI version management

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Apply internal revision suggestions

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Add ignored paths to sanitizer events

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Remove nightly files

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Remove Windows CI test report

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Remove unused action

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Address last rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Fix input branch on reusable windows CI

Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Manual cherry-pick of PR #4549

Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Add missing ci.meta

Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Fix metas as yml

Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Fix paths to .metas

Signed-off-by: EduPonz <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
Co-authored-by: EduPonz <[email protected]>
EduPonz added a commit that referenced this pull request Mar 14, 2024
@JesusPoderoso @EduPonz
Fix CI version management (#4482)
fa2c790 
* Refs #20542: Fix CI version management

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Apply internal revision suggestions

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Add ignored paths to sanitizer events

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Remove nightly files

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Remove Windows CI test report

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Remove unused action

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Set default Discovery Server latest TAG

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Address last rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Manual cherry-pick of PR #4549

Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Fix metas as yml

Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Fix paths to .metas

Signed-off-by: EduPonz <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
Co-authored-by: EduPonz <[email protected]>
EduPonz added a commit that referenced this pull request Mar 14, 2024
@JesusPoderoso @EduPonz
Fix CI version management (#4481)
0898631 
* Refs #20542: Fix CI version management

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Apply internal revision suggestions

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Add ignored paths to sanitizer events

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Remove nightly files

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Remove Windows CI test report

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Remove unused action

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Set default Discovery Server latest TAG

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Address last rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Fix input branch on reusable windows CI

Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Manual cherry-pick of PR #4549

Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Manual cherry-pick of PR #4456

Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Fix a couple of nitpicks

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
Co-authored-by: EduPonz <[email protected]>
@EduPonz EduPonz merged commit 276581e into master Mar 14, 2024
8 of 10 checks passed
@EduPonz EduPonz deleted the hotfix/fix_nightly_jobs branch March 14, 2024 06:42
@EduPonz EduPonz modified the milestones: v2.14.1, v2.14.0 - Frozen Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JesusPoderoso @EduPonz