-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20592] Fix hidden overloaded virtual methods (backport #4516) #4592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refs #20592: Fix for test Signed-off-by: EduPonz <[email protected]> * Refs #20592: Fix for examples Signed-off-by: EduPonz <[email protected]> * Refs #20592: Add more warning flags to Ubuntu CI Signed-off-by: EduPonz <[email protected]> * Refs #20592: Remove default values on overloaded PDPClient::announceParticipantState Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> (cherry picked from commit 63cc242) # Conflicts: # .github/workflows/reusable-ubuntu-ci.yml # examples/cpp/dds/DiscoveryServerExample/DiscoveryServerPublisher.h # examples/cpp/dds/DiscoveryServerExample/DiscoveryServerServer.h # examples/cpp/dds/DiscoveryServerExample/DiscoveryServerSubscriber.h # test/blackbox/common/DDSBlackboxTestsDataRepresentationQos.cpp # test/blackbox/common/DDSBlackboxTestsDiscovery.cpp # test/dds/communication/security/PublisherModule.hpp # test/dds/communication/security/SubscriberModule.hpp # test/unittest/statistics/dds/StatisticsDomainParticipantStatusQueryableTests.cpp
Cherry-pick of 63cc242 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
9 tasks
9 tasks
Closed in favor of: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this PR, compiling with GCC option
-Woverloaded-virtual
resulted in compilation warnings due to overloaded virtual methods being hidden in derived classes that do not override all the parent's overloads. This PR:@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x
Contributor Checklist
Commit messages follow the project guidelines.
N/A: The code follows the style guidelines of this project.
N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
N/A: New feature has been added to the
versions.md
file (if applicable).N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #4516 done by [Mergify](https://mergify.com).