[20648] Only run PRs CI when run-ci label is added #4599

EduPonz · 2024-03-22T10:25:55Z

Description

This PR changes the way Github CI is managed. From now on, to run CI, a reivew needs to be requested on the PR. Once the CI starts, the ci-pending label is added.

@Mergifyio backport 2.13.x 2.10.x 2.6.x

This PR depends on:

[20648] Add remove_labels and add_labels actions eProsima-CI#80

Contributor Checklist

Commit messages follow the project guidelines.
N/A: The code follows the style guidelines of this project.
N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
N/A: Changes are ABI compatible.
N/A: Changes are API compatible.
N/A: New feature has been added to the versions.md file (if applicable).
N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

JesusPoderoso

LGTM! 🚀

JesusPoderoso · 2024-03-22T12:17:08Z

@Mergifyio backport 2.13.x 2.10.x 2.6.x

mergify · 2024-03-22T12:17:23Z

backport 2.13.x 2.10.x 2.6.x

✅ Backports have been created

#4613 [20648] Only run PRs CI when run-ci label is added (backport #4599) has been created for branch 2.13.x but encountered conflicts
#4614 [20648] Only run PRs CI when run-ci label is added (backport #4599) has been created for branch 2.10.x but encountered conflicts
#4615 [20648] Only run PRs CI when run-ci label is added (backport #4599) has been created for branch 2.6.x but encountered conflicts

Signed-off-by: EduPonz <[email protected]>

…ctions Signed-off-by: EduPonz <[email protected]>

Signed-off-by: EduPonz <[email protected]>

JesusPoderoso

LGTM

EduPonz · 2024-03-25T10:07:40Z

Last commit only changed the trigger, which @JesusPoderoso tested. Since CI had run on the previous commit, I've cancelled CI and I'm merging this.

* Refs #20648: Only run PRs CI when run-ci label is added Signed-off-by: EduPonz <[email protected]> * Refs #20648: Correctly add ci-pending label Signed-off-by: EduPonz <[email protected]> * Refs #20648: Fix documentation trigger Signed-off-by: EduPonz <[email protected]> * Refs #20648: Add ci-pending label in mac CI Signed-off-by: EduPonz <[email protected]> * Refs #20648: Set eProsima-CI version to v0 on add and remove labels actions Signed-off-by: EduPonz <[email protected]> * Refs #20648: Change Github workflows trigger to 'review_requested' Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> (cherry picked from commit d0a334b) # Conflicts: # .github/workflows/address-sanitizers.yaml # .github/workflows/documentation-tests.yaml # .github/workflows/mac-ci.yml # .github/workflows/thread-sanitizer.yaml # .github/workflows/ubuntu-ci.yml # .github/workflows/windows-ci.yml

* Refs #20648: Only run PRs CI when run-ci label is added Signed-off-by: EduPonz <[email protected]> * Refs #20648: Correctly add ci-pending label Signed-off-by: EduPonz <[email protected]> * Refs #20648: Fix documentation trigger Signed-off-by: EduPonz <[email protected]> * Refs #20648: Add ci-pending label in mac CI Signed-off-by: EduPonz <[email protected]> * Refs #20648: Set eProsima-CI version to v0 on add and remove labels actions Signed-off-by: EduPonz <[email protected]> * Refs #20648: Change Github workflows trigger to 'review_requested' Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]>

* Refs #20648: Only run PRs CI when run-ci label is added Signed-off-by: EduPonz <[email protected]> * Refs #20648: Correctly add ci-pending label Signed-off-by: EduPonz <[email protected]> * Refs #20648: Fix documentation trigger Signed-off-by: EduPonz <[email protected]> * Refs #20648: Add ci-pending label in mac CI Signed-off-by: EduPonz <[email protected]> * Refs #20648: Set eProsima-CI version to v0 on add and remove labels actions Signed-off-by: EduPonz <[email protected]> * Refs #20648: Change Github workflows trigger to 'review_requested' Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> (cherry picked from commit d0a334b) # Conflicts: # .github/workflows/address-sanitizers.yaml # .github/workflows/documentation-tests.yaml # .github/workflows/mac-ci.yml # .github/workflows/thread-sanitizer.yaml # .github/workflows/ubuntu-ci.yml # .github/workflows/windows-ci.yml

* Only run PRs CI when run-ci label is added (#4599) * Refs #20648: Only run PRs CI when run-ci label is added Signed-off-by: EduPonz <[email protected]> * Refs #20648: Correctly add ci-pending label Signed-off-by: EduPonz <[email protected]> * Refs #20648: Fix documentation trigger Signed-off-by: EduPonz <[email protected]> * Refs #20648: Add ci-pending label in mac CI Signed-off-by: EduPonz <[email protected]> * Refs #20648: Set eProsima-CI version to v0 on add and remove labels actions Signed-off-by: EduPonz <[email protected]> * Refs #20648: Change Github workflows trigger to 'review_requested' Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> (cherry picked from commit d0a334b) # Conflicts: # .github/workflows/address-sanitizers.yaml # .github/workflows/documentation-tests.yaml # .github/workflows/mac-ci.yml # .github/workflows/thread-sanitizer.yaml # .github/workflows/ubuntu-ci.yml # .github/workflows/windows-ci.yml * Fix conflicts Signed-off-by: JesusPoderoso <[email protected]> --------- Signed-off-by: JesusPoderoso <[email protected]> Co-authored-by: Eduardo Ponz Segrelles <[email protected]> Co-authored-by: JesusPoderoso <[email protected]>

* Refs #20648: Only run PRs CI when run-ci label is added Signed-off-by: EduPonz <[email protected]> * Refs #20648: Correctly add ci-pending label Signed-off-by: EduPonz <[email protected]> * Refs #20648: Fix documentation trigger Signed-off-by: EduPonz <[email protected]> * Refs #20648: Add ci-pending label in mac CI Signed-off-by: EduPonz <[email protected]> * Refs #20648: Set eProsima-CI version to v0 on add and remove labels actions Signed-off-by: EduPonz <[email protected]> * Refs #20648: Change Github workflows trigger to 'review_requested' Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> (cherry picked from commit d0a334b)

* Refs #20648: Only run PRs CI when run-ci label is added Signed-off-by: EduPonz <[email protected]> * Refs #20648: Correctly add ci-pending label Signed-off-by: EduPonz <[email protected]> * Refs #20648: Fix documentation trigger Signed-off-by: EduPonz <[email protected]> * Refs #20648: Add ci-pending label in mac CI Signed-off-by: EduPonz <[email protected]> * Refs #20648: Set eProsima-CI version to v0 on add and remove labels actions Signed-off-by: EduPonz <[email protected]> * Refs #20648: Change Github workflows trigger to 'review_requested' Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> (cherry picked from commit d0a334b) Co-authored-by: Eduardo Ponz Segrelles <[email protected]>

EduPonz added this to the v2.14.1 milestone Mar 22, 2024

EduPonz force-pushed the ci/github_ubuntu_ci_prs branch from cfd6d9d to d7c2654 Compare March 22, 2024 10:27

EduPonz added the run-ci label Mar 22, 2024

github-actions bot removed the run-ci label Mar 22, 2024

EduPonz added the run-ci label Mar 22, 2024

github-actions bot added ci-pending PR which CI is running and removed run-ci ci-pending PR which CI is running labels Mar 22, 2024

EduPonz added the run-ci label Mar 22, 2024

github-actions bot removed run-ci ci-pending PR which CI is running labels Mar 22, 2024

EduPonz added the run-ci label Mar 22, 2024

github-actions bot added ci-pending PR which CI is running and removed run-ci labels Mar 22, 2024

JesusPoderoso previously approved these changes Mar 22, 2024

View reviewed changes

EduPonz dismissed JesusPoderoso’s stale review via 63bc04a March 22, 2024 12:02

EduPonz added run-ci and removed ci-pending PR which CI is running labels Mar 22, 2024

github-actions bot added ci-pending PR which CI is running and removed run-ci labels Mar 22, 2024

JesusPoderoso previously approved these changes Mar 22, 2024

View reviewed changes

JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Mar 22, 2024

EduPonz added 4 commits March 25, 2024 10:48

Refs #20648: Only run PRs CI when run-ci label is added

919e525

Signed-off-by: EduPonz <[email protected]>

Refs #20648: Correctly add ci-pending label

8ab0955

Signed-off-by: EduPonz <[email protected]>

Refs #20648: Fix documentation trigger

39a264c

Signed-off-by: EduPonz <[email protected]>

Refs #20648: Add ci-pending label in mac CI

cc69196

Signed-off-by: EduPonz <[email protected]>

EduPonz added 2 commits March 25, 2024 10:48

Refs #20648: Set eProsima-CI version to v0 on add and remove labels a…

843a675

…ctions Signed-off-by: EduPonz <[email protected]>

Refs #20648: Change Github workflows trigger to 'review_requested'

ae1fafd

Signed-off-by: EduPonz <[email protected]>

EduPonz dismissed JesusPoderoso’s stale review via ae1fafd March 25, 2024 09:58

EduPonz force-pushed the ci/github_ubuntu_ci_prs branch from 63bc04a to ae1fafd Compare March 25, 2024 09:58

JesusPoderoso self-requested a review March 25, 2024 09:59

github-actions bot added the ci-pending PR which CI is running label Mar 25, 2024

JesusPoderoso removed the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Mar 25, 2024

JesusPoderoso approved these changes Mar 25, 2024

View reviewed changes

EduPonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Mar 25, 2024

EduPonz merged commit d0a334b into master Mar 25, 2024
3 of 11 checks passed

EduPonz deleted the ci/github_ubuntu_ci_prs branch March 25, 2024 10:08

mergify bot mentioned this pull request Mar 25, 2024

[20648] Only run PRs CI when run-ci label is added (backport #4599) #4613

Merged

7 tasks

mergify bot mentioned this pull request Mar 25, 2024

[20648] Only run PRs CI when run-ci label is added (backport #4599) #4614

Merged

7 tasks

mergify bot mentioned this pull request Mar 25, 2024

[20648] Only run PRs CI when run-ci label is added (backport #4599) #4615

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[20648] Only run PRs CI when run-ci label is added #4599

[20648] Only run PRs CI when run-ci label is added #4599

EduPonz commented Mar 22, 2024 •

edited

Loading

JesusPoderoso left a comment

JesusPoderoso commented Mar 22, 2024

mergify bot commented Mar 22, 2024 •

edited

Loading

JesusPoderoso left a comment

EduPonz commented Mar 25, 2024

[20648] Only run PRs CI when run-ci label is added #4599

[20648] Only run PRs CI when run-ci label is added #4599

Conversation

EduPonz commented Mar 22, 2024 • edited Loading

Description

Contributor Checklist

Reviewer Checklist

JesusPoderoso left a comment

Choose a reason for hiding this comment

JesusPoderoso commented Mar 22, 2024

mergify bot commented Mar 22, 2024 • edited Loading

✅ Backports have been created

JesusPoderoso left a comment

Choose a reason for hiding this comment

EduPonz commented Mar 25, 2024

EduPonz commented Mar 22, 2024 •

edited

Loading

mergify bot commented Mar 22, 2024 •

edited

Loading