-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20701] Enforce SHM ports open mode exclusions #4635
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
MiguelCompany
force-pushed
the
bugfix/20701
branch
from
March 27, 2024 16:19
5341a7e
to
f260efa
Compare
EduPonz
approved these changes
Apr 2, 2024
@Mergifyio backport 2.13.x 2.10.x 2.6.x |
✅ Backports have been created
|
@richiprosima please test this |
EduPonz
approved these changes
Apr 2, 2024
mergify bot
pushed a commit
that referenced
this pull request
Apr 3, 2024
* Refs #20701. Added unit regression tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20701. Added blackbox regression test. Signed-off-by: Miguel Company <[email protected]> * Refs #20701. Fix issue. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 3d159dc)
mergify bot
pushed a commit
that referenced
this pull request
Apr 3, 2024
* Refs #20701. Added unit regression tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20701. Added blackbox regression test. Signed-off-by: Miguel Company <[email protected]> * Refs #20701. Fix issue. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 3d159dc) # Conflicts: # test/blackbox/common/BlackboxTestsTransportSHM.cpp
mergify bot
pushed a commit
that referenced
this pull request
Apr 3, 2024
* Refs #20701. Added unit regression tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20701. Added blackbox regression test. Signed-off-by: Miguel Company <[email protected]> * Refs #20701. Fix issue. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 3d159dc) # Conflicts: # test/blackbox/common/BlackboxTestsTransportSHM.cpp
This was referenced Apr 3, 2024
MiguelCompany
added a commit
that referenced
this pull request
Apr 12, 2024
* Enforce SHM ports open mode exclusions (#4635) * Refs #20701. Added unit regression tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20701. Added blackbox regression test. Signed-off-by: Miguel Company <[email protected]> * Refs #20701. Fix issue. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 3d159dc) # Conflicts: # test/blackbox/common/BlackboxTestsTransportSHM.cpp * Fix conflicts Signed-off-by: Miguel Company <[email protected]> * Fix build on unit test Signed-off-by: Miguel Company <[email protected]> * Fix build on unit test Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Miguel Company <[email protected]>
EduPonz
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Refs #20701. Added unit regression tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20701. Added blackbox regression test. Signed-off-by: Miguel Company <[email protected]> * Refs #20701. Fix issue. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 3d159dc) Co-authored-by: Miguel Company <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As originally reported in #4504 a port could be open first with ReadShared and then with ReadExclusive the internal state of the port was incorrectly changed. This meant that the same port could be used at the same time for unicast and multicast.
This PR fixes #4634 by checking incompatibilities inside
lock_read_exlcusive
/lock_read_shared
methods of the Port class.@Mergifyio backport 2.13.x 2.10.x 2.6.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist