-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20709] Make rtps messages headers private #4657
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
274b31d
to
635968e
Compare
88527b5
to
02e9b57
Compare
This was referenced Apr 5, 2024
4e6bea8
to
27a861e
Compare
7a602df
to
b0e2e65
Compare
Base automatically changed from
feature/typelookup-listeners-implementation
to
3.0.x-devel
April 10, 2024 14:27
943b988
to
2c47b5e
Compare
2c47b5e
to
c978d52
Compare
5148f5d
to
bd83bb2
Compare
02e9b57
to
a8ef6e5
Compare
08ee62b
to
623db82
Compare
a8ef6e5
to
379bc9e
Compare
@richiprosima test linux |
86131c7
to
8ca5e27
Compare
Signed-off-by: elianalf <[email protected]>
8ca5e27
to
f5d116a
Compare
Signed-off-by: elianalf <[email protected]>
4867ee6
to
333b767
Compare
Merged
6 tasks
Signed-off-by: elianalf <[email protected]>
333b767
to
d3abbcd
Compare
@richiprosima test windows |
@richiprosima please test_3 this |
EduPonz
reviewed
May 23, 2024
EduPonz
suggested changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor NITs. There are some still open points as well
Signed-off-by: elianalf <[email protected]>
6a69ea3
to
6481ed8
Compare
@richiprosima please test_3 this |
EduPonz
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make rtps messages headers private :
Related PR:
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist