-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20816] Properly delete builtin statistics writers upon delete_contained_entities()
(backport #4891)
#4917
Conversation
…ities()` (#4891) * Refs #20816: Add BB test Signed-off-by: Mario Dominguez <[email protected]> * Refs #20816: Fix Signed-off-by: Mario Dominguez <[email protected]> * Refs #20816: Apply Edu's suggestion Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit 0d62335) # Conflicts: # src/cpp/statistics/fastdds/domain/DomainParticipantImpl.cpp # src/cpp/statistics/fastdds/domain/DomainParticipantImpl.hpp
Cherry-pick of 0d62335 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
852bc9a
to
c794a0d
Compare
c794a0d
to
60e3d8b
Compare
60e3d8b
to
9438662
Compare
9438662
to
b1ba952
Compare
b1ba952
to
0a3ff96
Compare
Signed-off-by: Mario Dominguez <[email protected]>
0a3ff96
to
5022e56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, failed tests are unrelated to the changes
Description
This PR fixes a wrong behavior that occurs when closing an application making an intensive use of statistics. If in the shutdown pipeline, after a manual removal of entities (
delete_datareader
,delete_subscriber
,delete_topic
) ifdelete_contained_entities()
was called, it caused a race when alive endpoints try to keep using the statistics builtin endpoints (writers).@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
New feature has been added to the
versions.md
file (if applicable).New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #4891 done by [Mergify](https://mergify.com).