-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21165] Correctly initialize MatchingFailureMask
constants to be used with the std::bitset
API
#4922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
EduPonz
force-pushed
the
bugfix/matching_failure_mask
branch
from
June 10, 2024 09:50
8dc903e
to
c3c987b
Compare
richiware
requested changes
Jun 10, 2024
Signed-off-by: eduponz <[email protected]>
@richiprosima please test discovery-server |
richiware
approved these changes
Jun 10, 2024
EduPonz
changed the title
[21165] Correctly initialize
[21165] Correctly initialize Jun 10, 2024
MatchingFailureMask
constants to be used with the std::bitset
API.MatchingFailureMask
constants to be used with the std::bitset
API
@richiprosima please test_3 discovery-server |
EduPonz
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
Jun 10, 2024
@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
…the `std::bitset` API (#4922) * Refs #21165: Add regression test Signed-off-by: eduponz <[email protected]> * Refs #21165: Init MatchingFailureMask constants as normal uints Signed-off-by: eduponz <[email protected]> * Refs #21165: Apply Ricardo's suggestions Signed-off-by: eduponz <[email protected]> --------- Signed-off-by: eduponz <[email protected]> (cherry picked from commit 5e1f1dd) # Conflicts: # include/fastdds/rtps/builtin/discovery/endpoint/EDP.h
11 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
…the `std::bitset` API (#4922) * Refs #21165: Add regression test Signed-off-by: eduponz <[email protected]> * Refs #21165: Init MatchingFailureMask constants as normal uints Signed-off-by: eduponz <[email protected]> * Refs #21165: Apply Ricardo's suggestions Signed-off-by: eduponz <[email protected]> --------- Signed-off-by: eduponz <[email protected]> (cherry picked from commit 5e1f1dd) # Conflicts: # include/fastdds/rtps/builtin/discovery/endpoint/EDP.h
11 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
…the `std::bitset` API (#4922) * Refs #21165: Add regression test Signed-off-by: eduponz <[email protected]> * Refs #21165: Init MatchingFailureMask constants as normal uints Signed-off-by: eduponz <[email protected]> * Refs #21165: Apply Ricardo's suggestions Signed-off-by: eduponz <[email protected]> --------- Signed-off-by: eduponz <[email protected]> (cherry picked from commit 5e1f1dd) # Conflicts: # include/fastdds/rtps/builtin/discovery/endpoint/EDP.h # test/unittest/rtps/discovery/EdpTests.cpp
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
…the `std::bitset` API (#4922) * Refs #21165: Add regression test Signed-off-by: eduponz <[email protected]> * Refs #21165: Init MatchingFailureMask constants as normal uints Signed-off-by: eduponz <[email protected]> * Refs #21165: Apply Ricardo's suggestions Signed-off-by: eduponz <[email protected]> --------- Signed-off-by: eduponz <[email protected]> (cherry picked from commit 5e1f1dd) # Conflicts: # include/fastdds/rtps/builtin/discovery/endpoint/EDP.h # test/unittest/rtps/discovery/EdpTests.cpp
EduPonz
added a commit
that referenced
this pull request
Jun 11, 2024
…the `std::bitset` API (#4922) * Refs #21165: Add regression test Signed-off-by: eduponz <[email protected]> * Refs #21165: Init MatchingFailureMask constants as normal uints Signed-off-by: eduponz <[email protected]> * Refs #21165: Apply Ricardo's suggestions Signed-off-by: eduponz <[email protected]> --------- Signed-off-by: eduponz <[email protected]> (cherry picked from commit 5e1f1dd)
EduPonz
added a commit
that referenced
this pull request
Jun 11, 2024
…the `std::bitset` API (#4922) * Refs #21165: Add regression test Signed-off-by: eduponz <[email protected]> * Refs #21165: Init MatchingFailureMask constants as normal uints Signed-off-by: eduponz <[email protected]> * Refs #21165: Apply Ricardo's suggestions Signed-off-by: eduponz <[email protected]> --------- Signed-off-by: eduponz <[email protected]> (cherry picked from commit 5e1f1dd)
EduPonz
added a commit
that referenced
this pull request
Jun 11, 2024
…the `std::bitset` API (#4922) * Refs #21165: Add regression test Signed-off-by: eduponz <[email protected]> * Refs #21165: Init MatchingFailureMask constants as normal uints Signed-off-by: eduponz <[email protected]> * Refs #21165: Apply Ricardo's suggestions Signed-off-by: eduponz <[email protected]> --------- Signed-off-by: eduponz <[email protected]> (cherry picked from commit 5e1f1dd)
EduPonz
added a commit
that referenced
this pull request
Jun 11, 2024
…the `std::bitset` API (#4922) (#4925) * Refs #21165: Add regression test Signed-off-by: eduponz <[email protected]> * Refs #21165: Init MatchingFailureMask constants as normal uints Signed-off-by: eduponz <[email protected]> * Refs #21165: Apply Ricardo's suggestions Signed-off-by: eduponz <[email protected]> --------- Signed-off-by: eduponz <[email protected]> (cherry picked from commit 5e1f1dd) Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
EduPonz
added a commit
that referenced
this pull request
Jun 17, 2024
…the `std::bitset` API (#4922) * Refs #21165: Add regression test Signed-off-by: eduponz <[email protected]> * Refs #21165: Init MatchingFailureMask constants as normal uints Signed-off-by: eduponz <[email protected]> * Refs #21165: Apply Ricardo's suggestions Signed-off-by: eduponz <[email protected]> --------- Signed-off-by: eduponz <[email protected]> (cherry picked from commit 5e1f1dd) # Conflicts: # include/fastdds/rtps/builtin/discovery/endpoint/EDP.h # test/unittest/rtps/discovery/EdpTests.cpp
EduPonz
added a commit
that referenced
this pull request
Jun 18, 2024
…the `std::bitset` API (#4922) (#4928) * Correctly initialize `MatchingFailureMask` constants to be used with the `std::bitset` API (#4922) * Refs #21165: Add regression test Signed-off-by: eduponz <[email protected]> * Refs #21165: Init MatchingFailureMask constants as normal uints Signed-off-by: eduponz <[email protected]> * Refs #21165: Apply Ricardo's suggestions Signed-off-by: eduponz <[email protected]> --------- Signed-off-by: eduponz <[email protected]> (cherry picked from commit 5e1f1dd) # Conflicts: # include/fastdds/rtps/builtin/discovery/endpoint/EDP.h # test/unittest/rtps/discovery/EdpTests.cpp * Solve conflicts Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> Co-authored-by: Eduardo Ponz Segrelles <[email protected]> Co-authored-by: Mario Dominguez <[email protected]>
EduPonz
added a commit
that referenced
this pull request
Jun 18, 2024
…the `std::bitset` API (#4922) (#4926) * Refs #21165: Add regression test Signed-off-by: eduponz <[email protected]> * Refs #21165: Init MatchingFailureMask constants as normal uints Signed-off-by: eduponz <[email protected]> * Refs #21165: Apply Ricardo's suggestions Signed-off-by: eduponz <[email protected]> --------- Signed-off-by: eduponz <[email protected]> (cherry picked from commit 5e1f1dd) Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
MiguelCompany
pushed a commit
that referenced
this pull request
Jun 19, 2024
…the `std::bitset` API (#4922) (#4927) * Refs #21165: Add regression test Signed-off-by: eduponz <[email protected]> * Refs #21165: Init MatchingFailureMask constants as normal uints Signed-off-by: eduponz <[email protected]> * Refs #21165: Apply Ricardo's suggestions Signed-off-by: eduponz <[email protected]> --------- Signed-off-by: eduponz <[email protected]> (cherry picked from commit 5e1f1dd) Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the values of the
MatchingFailureMask
so they can be directly used through thestd::bitset
API. Before this PR, the following code:resulted in a C++ exception as follows:
@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist