Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21052] Make ChangeForReader, ReaderLocator, ReaderProxy private #4923

Merged
merged 7 commits into from
Jun 11, 2024
Merged

[21052] Make ChangeForReader, ReaderLocator, ReaderProxy private #4923

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
da52650
Refs #21052: Move ReaderLocator, ChangeForReader and ReaderProxy to p…
Mario-DL Jun 5, 2024
4c42ad8
Refs #21052: Update source files headers
Mario-DL Jun 5, 2024
91bd690
Refs #21052: Update mock path and unittests accordingly
Mario-DL Jun 5, 2024
bf265d6
Refs #21052: Update versions.md
Mario-DL Jun 5, 2024
b85d461
Refs #21052: Rev suggestion: Correct header guards & make .hpp
Mario-DL Jun 7, 2024
90dffac
Refs #21052: Rev suggestion: change source files references
Mario-DL Jun 7, 2024
ed9a450
Refs #21052: Apply second review changes
Mario-DL Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Refs #21052: Apply second review changes 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
  • Loading branch information
@Mario-DL
Mario-DL committed Jun 10, 2024
commit ed9a4502a6dfb3825615a9133ad9a49d9b919e80
6 changes: 1 addition & 5 deletions src/cpp/rtps/writer/ChangeForReader.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ namespace eprosima {
namespace fastrtps {
namespace rtps {

#ifndef DOXYGEN_SHOULD_SKIP_THIS_PUBLIC

/**
* Enum ChangeForReaderStatus_t, possible states for a CacheChange_t in a ReaderProxy.
* @ingroup COMMON_MODULE
Expand Down Expand Up @@ -207,10 +205,8 @@ struct ChangeForReaderCmp

};

#endif // ifndef DOXYGEN_SHOULD_SKIP_THIS_PUBLIC

} // namespace rtps
} // namespace fastrtps
} // namespace eprosima

#endif /* RTPS_WRITER__CHANGEFORREADER_HPP */
#endif // RTPS_WRITER__CHANGEFORREADER_HPP
5 changes: 1 addition & 4 deletions src/cpp/rtps/writer/ReaderLocator.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@
#ifndef RTPS_WRITER__READERLOCATOR_HPP
#define RTPS_WRITER__READERLOCATOR_HPP

#ifndef DOXYGEN_SHOULD_SKIP_THIS_PUBLIC

#include <vector>
#include <fastdds/rtps/common/Locator.h>
#include <fastdds/rtps/common/Guid.h>
Expand Down Expand Up @@ -270,5 +268,4 @@ class ReaderLocator : public RTPSMessageSenderInterface
} /* namespace fastrtps */
} /* namespace eprosima */

#endif // ifndef DOXYGEN_SHOULD_SKIP_THIS_PUBLIC
#endif /* RTPS_WRITER__READERLOCATOR_HPP */
#endif // RTPS_WRITER__READERLOCATOR_HPP
5 changes: 1 addition & 4 deletions src/cpp/rtps/writer/ReaderProxy.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@
#ifndef RTPS_WRITER__READERPROXY_HPP
#define RTPS_WRITER__READERPROXY_HPP

#ifndef DOXYGEN_SHOULD_SKIP_THIS_PUBLIC

#include <algorithm>
#include <atomic>
#include <mutex>
Expand Down Expand Up @@ -506,5 +504,4 @@ class ReaderProxy
} /* namespace fastrtps */
} /* namespace eprosima */

#endif // ifndef DOXYGEN_SHOULD_SKIP_THIS_PUBLIC
#endif /* RTPS_WRITER__READERPROXY_HPP */
#endif // RTPS_WRITER__READERPROXY_HPP
4 changes: 1 addition & 3 deletions test/mock/rtps/ReaderLocator/rtps/writer/ReaderLocator.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

#ifndef RTPS_WRITER__READERLOCATOR_HPP
#define RTPS_WRITER__READERLOCATOR_HPP
#ifndef DOXYGEN_SHOULD_SKIP_THIS_PUBLIC

#include <vector>

Expand Down Expand Up @@ -255,5 +254,4 @@ class ReaderLocator : public RTPSMessageSenderInterface
} /* namespace fastrtps */
} /* namespace eprosima */

#endif // ifndef DOXYGEN_SHOULD_SKIP_THIS_PUBLIC
#endif /* RTPS_WRITER__READERLOCATOR_HPP*/
#endif // RTPS_WRITER__READERLOCATOR_HPP
Loading