-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20650] Create InitialConnection for TCP initial peers 2.13 & 2.10 & 2.6 #4947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cferreiragonz
force-pushed
the
bugfix/initial_peers_tcp_2.13
branch
from
June 14, 2024 07:16
1ad97de
to
ee8360a
Compare
@Mergifyio backport 2.10.x 2.6.x |
✅ Backports have been created
|
JesusPoderoso
previously approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
cferreiragonz
force-pushed
the
bugfix/initial_peers_tcp_2.13
branch
from
June 18, 2024 15:01
ee8360a
to
356eb4c
Compare
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
cferreiragonz
force-pushed
the
bugfix/initial_peers_tcp_2.13
branch
from
June 18, 2024 15:02
356eb4c
to
7177aa1
Compare
JesusPoderoso
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
JesusPoderoso
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
Jun 26, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
* Refs #20650: Add test Signed-off-by: cferreiragonz <[email protected]> * Refs #20650: Create initial connect for initial peers Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit a0a4fee)
mergify bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
* Refs #20650: Add test Signed-off-by: cferreiragonz <[email protected]> * Refs #20650: Create initial connect for initial peers Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit a0a4fee) # Conflicts: # test/blackbox/common/BlackboxTestsTransportTCP.cpp
cferreiragonz
added a commit
that referenced
this pull request
Jun 27, 2024
* Refs #20650: Add test Signed-off-by: cferreiragonz <[email protected]> * Refs #20650: Create initial connect for initial peers Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit a0a4fee) # Conflicts: # test/blackbox/common/BlackboxTestsTransportTCP.cpp
EduPonz
pushed a commit
that referenced
this pull request
Jul 3, 2024
…) (#5003) * Create InitialConnection for TCP initial peers 2.13 & 2.10 & 2.6 (#4947) * Refs #20650: Add test Signed-off-by: cferreiragonz <[email protected]> * Refs #20650: Create initial connect for initial peers Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit a0a4fee) # Conflicts: # test/blackbox/common/BlackboxTestsTransportTCP.cpp * Remove TCP lock_guard in disconnection Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> Co-authored-by: Carlos Ferreira González <[email protected]>
MiguelCompany
pushed a commit
that referenced
this pull request
Jul 31, 2024
* Refs #20650: Add test Signed-off-by: cferreiragonz <[email protected]> * Refs #20650: Create initial connect for initial peers Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit a0a4fee)
MiguelCompany
pushed a commit
that referenced
this pull request
Aug 28, 2024
* Refs #20650: Add test Signed-off-by: cferreiragonz <[email protected]> * Refs #20650: Create initial connect for initial peers Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit a0a4fee)
MiguelCompany
pushed a commit
that referenced
this pull request
Sep 20, 2024
* Refs #20650: Add test Signed-off-by: cferreiragonz <[email protected]> * Refs #20650: Create initial connect for initial peers Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit a0a4fee)
MiguelCompany
pushed a commit
that referenced
this pull request
Oct 28, 2024
* Refs #20650: Add test Signed-off-by: cferreiragonz <[email protected]> * Refs #20650: Create initial connect for initial peers Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit a0a4fee)
cferreiragonz
added a commit
that referenced
this pull request
Nov 8, 2024
* Refs #20650: Add test Signed-off-by: cferreiragonz <[email protected]> * Refs #20650: Create initial connect for initial peers Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit a0a4fee)
MiguelCompany
pushed a commit
that referenced
this pull request
Nov 9, 2024
* Refs #20650: Add test Signed-off-by: cferreiragonz <[email protected]> * Refs #20650: Create initial connect for initial peers Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit a0a4fee)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses the features introduced in #4584 to ALWAYS create a connection channel for the TCP when initial peers are configured.
@Mergifyio backport 2.10.x 2.6.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist