Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21808] DataWriter/Reader get_matched_publication/subscription() Tests & Feature 3.x #5312

Merged
merged 6 commits into from
Oct 25, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Oct 9, 2024

Description

This PR is a forward port of #5284, implementing the following APIs

DDS

  • DataWriter::get_matched_subscriptions()
  • DataWriter::get_matched_subscription_data()
  • DataReader::get_matched_publications()
  • DataReader::get_matched_publication_data()

RTPS

  • RTPSParticipant::get_publication_info()
  • RTPSParticipant::get_subscription_info()
  • RTPSReader::matched_writers_guids()
  • RTPSWriter::matched_readers_guids()

In the 3.x series.

Related PRs:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v3.2.0 milestone Oct 9, 2024
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima October 9, 2024 08:35
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 9, 2024
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima October 9, 2024 12:55
@richiware richiware self-requested a review October 17, 2024 08:03
Copy link
Member

@richiware richiware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also pending a PR to Python bindings.

src/cpp/fastdds/publisher/DataWriterImpl.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/publisher/DataWriterImpl.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/publisher/DataWriterImpl.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/publisher/DataWriterImpl.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/subscriber/DataReaderImpl.hpp Outdated Show resolved Hide resolved
src/cpp/rtps/reader/StatelessReader.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/writer/StatefulWriter.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/writer/StatefulWriter.cpp Show resolved Hide resolved
src/cpp/rtps/writer/StatelessWriter.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/writer/StatelessWriter.cpp Show resolved Hide resolved
… Test implementation 3.x

Signed-off-by: Mario Dominguez <[email protected]>
… Feature implementation 3.x

Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
src/cpp/rtps/writer/StatefulWriter.cpp Outdated Show resolved Hide resolved
@Mario-DL Mario-DL requested a review from richiware October 24, 2024 08:08
@Mario-DL Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Oct 25, 2024
@MiguelCompany MiguelCompany merged commit 4b00904 into master Oct 25, 2024
16 of 17 checks passed
@MiguelCompany MiguelCompany deleted the feature/21808 branch October 25, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants