-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21808] DataWriter/Reader get_matched_publication/subscription()
Tests & Feature 3.x
#5312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Mario-DL
requested review from
richiprosima
and removed request for
richiprosima
October 9, 2024 08:35
Mario-DL
requested review from
richiprosima
and removed request for
richiprosima
October 9, 2024 12:55
richiware
requested changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also pending a PR to Python bindings.
… Test implementation 3.x Signed-off-by: Mario Dominguez <[email protected]>
… Feature implementation 3.x Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Mario-DL
force-pushed
the
feature/21808
branch
from
October 18, 2024 07:18
23914aa
to
7559328
Compare
richiware
requested changes
Oct 24, 2024
Signed-off-by: Mario-DL <[email protected]>
richiware
approved these changes
Oct 25, 2024
Mario-DL
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a forward port of #5284, implementing the following APIs
DDS
DataWriter::get_matched_subscriptions()
DataWriter::get_matched_subscription_data()
DataReader::get_matched_publications()
DataReader::get_matched_publication_data()
RTPS
RTPSParticipant::get_publication_info()
RTPSParticipant::get_subscription_info()
RTPSReader::matched_writers_guids()
RTPSWriter::matched_readers_guids()
In the
3.x
series.Related PRs:
get_matched_publication/subscription...()
(2.x) API tests Fast-DDS-python#188Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist