Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix -Werror=template-id-cdtor #5341

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Fix -Werror=template-id-cdtor #5341

merged 1 commit into from
Nov 26, 2024

Conversation

kistlin
Copy link
Contributor

@kistlin kistlin commented Oct 17, 2024 •
edited by Mario-DL
Loading

Description

solves error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Fixes #5340

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@kistlin
fix eProsima#5340: -Werror=template-id-cdtor in C++20
309db65 
error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]
@JesusPoderoso
Copy link
Contributor

Hi @kistlin, thanks for your contribution!

@JesusPoderoso JesusPoderoso added the no-test Skip CI tests if PR marked with this label label Oct 31, 2024
@JesusPoderoso JesusPoderoso self-requested a review October 31, 2024 08:26
@JesusPoderoso JesusPoderoso added this to the v3.2.0 milestone Oct 31, 2024
Mario-DL
Mario-DL approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mario-DL Mario-DL changed the title fix #5340: -Werror=template-id-cdtor in C++20 Fix -Werror=template-id-cdtor Nov 26, 2024
@Mario-DL Mario-DL added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Nov 26, 2024
@MiguelCompany MiguelCompany merged commit 81f0069 into eProsima:master Nov 26, 2024
14 checks passed
@MiguelCompany
Copy link
Member

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 26, 2024 •
edited
Loading

backport 3.1.x 3.0.x 2.14.x 2.10.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 26, 2024
@kistlin @mergify
Fix build with -Werror=template-id-cdtor (#5341)
ccb1ea0 
error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]
(cherry picked from commit 81f0069)
@mergify mergify bot mentioned this pull request Nov 26, 2024
Merged
9 tasks
mergify bot pushed a commit that referenced this pull request Nov 26, 2024
@kistlin @mergify
Fix build with -Werror=template-id-cdtor (#5341)
8b1aea0 
error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]
(cherry picked from commit 81f0069)
@mergify mergify bot mentioned this pull request Nov 26, 2024
Merged
9 tasks
mergify bot pushed a commit that referenced this pull request Nov 26, 2024
@kistlin @mergify
Fix build with -Werror=template-id-cdtor (#5341)
4f54e64 
error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]
(cherry picked from commit 81f0069)
mergify bot pushed a commit that referenced this pull request Nov 26, 2024
@kistlin @mergify
Fix build with -Werror=template-id-cdtor (#5341)
8c8287b 
error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]
(cherry picked from commit 81f0069)
This was referenced Nov 26, 2024
Open
Open
MiguelCompany pushed a commit that referenced this pull request Dec 3, 2024
@mergify @kistlin
Fix build with -Werror=template-id-cdtor (#5341) (#5421)
d930486 
error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]
(cherry picked from commit 81f0069)

Co-authored-by: kistlin <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Dec 11, 2024
@mergify @kistlin
Fix build with -Werror=template-id-cdtor (#5341) (#5420)
cbe6216 
error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]
(cherry picked from commit 81f0069)

Co-authored-by: kistlin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

@JesusPoderoso JesusPoderoso Awaiting requested review from JesusPoderoso

Assignees
No one assigned
Labels
no-test Skip CI tests if PR marked with this label ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

Build error because of -Werror=template-id-cdtor in C++20
4 participants
@kistlin @JesusPoderoso @MiguelCompany @Mario-DL