-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[22055] Fix unique network flows with TCP transports #5461
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
MiguelCompany
requested changes
Dec 10, 2024
Signed-off-by: cferreiragonz <[email protected]>
d981ae8
to
9d5f9ba
Compare
MiguelCompany
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
* Refs #22055: Add regression tests Signed-off-by: cferreiragonz <[email protected]> * Refs #22055: Fix unique flows for TCP Signed-off-by: cferreiragonz <[email protected]> * Refs #22055: Fix tests Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit 81cdb10)
13 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
* Refs #22055: Add regression tests Signed-off-by: cferreiragonz <[email protected]> * Refs #22055: Fix unique flows for TCP Signed-off-by: cferreiragonz <[email protected]> * Refs #22055: Fix tests Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit 81cdb10)
mergify bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
* Refs #22055: Add regression tests Signed-off-by: cferreiragonz <[email protected]> * Refs #22055: Fix unique flows for TCP Signed-off-by: cferreiragonz <[email protected]> * Refs #22055: Fix tests Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit 81cdb10)
This was referenced Dec 11, 2024
mergify bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
* Refs #22055: Add regression tests Signed-off-by: cferreiragonz <[email protected]> * Refs #22055: Fix unique flows for TCP Signed-off-by: cferreiragonz <[email protected]> * Refs #22055: Fix tests Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit 81cdb10) # Conflicts: # test/blackbox/common/BlackboxTestsTransportTCP.cpp
13 tasks
MiguelCompany
pushed a commit
that referenced
this pull request
Dec 12, 2024
* Refs #22055: Add regression tests Signed-off-by: cferreiragonz <[email protected]> * Refs #22055: Fix unique flows for TCP Signed-off-by: cferreiragonz <[email protected]> * Refs #22055: Fix tests Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit 81cdb10) Co-authored-by: Carlos Ferreira González <[email protected]>
MiguelCompany
pushed a commit
that referenced
this pull request
Dec 17, 2024
* Fix unique network flows with TCP transports (#5461) * Refs #22055: Add regression tests Signed-off-by: cferreiragonz <[email protected]> * Refs #22055: Fix unique flows for TCP Signed-off-by: cferreiragonz <[email protected]> * Refs #22055: Fix tests Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit 81cdb10) * Solve 2.14 conflicts Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> Co-authored-by: Carlos Ferreira González <[email protected]>
MiguelCompany
pushed a commit
that referenced
this pull request
Dec 18, 2024
* Refs #22055: Add regression tests Signed-off-by: cferreiragonz <[email protected]> * Refs #22055: Fix unique flows for TCP Signed-off-by: cferreiragonz <[email protected]> * Refs #22055: Fix tests Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit 81cdb10) Co-authored-by: Carlos Ferreira González <[email protected]>
11 tasks
This was referenced Jan 22, 2025
Merged
Merged
Merged
MiguelCompany
pushed a commit
that referenced
this pull request
Jan 29, 2025
* Fix unique network flows with TCP transports (#5461) * Refs #22055: Add regression tests Signed-off-by: cferreiragonz <[email protected]> * Refs #22055: Fix unique flows for TCP Signed-off-by: cferreiragonz <[email protected]> * Refs #22055: Fix tests Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit 81cdb10) # Conflicts: # test/blackbox/common/BlackboxTestsTransportTCP.cpp * Solve conflicts Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> Co-authored-by: Carlos Ferreira González <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the behavior of Unique Network Flows with TCP transports. When activated, the logical port should be changed instead of modifying the physical port. This allows the communication of participants with TCP transports and the
fastdds.unique_network_flows
property activated, ensuring that the listening port specified is not modified.@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist