-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[22440] Malformed packets in Fast DDS 3 #5466
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo González Moreno <[email protected]>
richiware
changed the title
Malformed packets in Fast DDS 3
[22440] Malformed packets in Fast DDS 3
Dec 5, 2024
cferreiragonz
requested changes
Dec 5, 2024
Co-authored-by: Carlos Ferreira González <[email protected]>
cferreiragonz
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
@Mergifyio backport 3.1.x 3.0.x |
✅ Backports have been created
|
MiguelCompany
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
Dec 9, 2024
mergify bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
* Refs #22439. Fix Signed-off-by: Ricardo González Moreno <[email protected]> * Apply suggestions from code review Co-authored-by: Carlos Ferreira González <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]> Co-authored-by: Carlos Ferreira González <[email protected]> (cherry picked from commit 885878d)
11 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
* Refs #22439. Fix Signed-off-by: Ricardo González Moreno <[email protected]> * Apply suggestions from code review Co-authored-by: Carlos Ferreira González <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]> Co-authored-by: Carlos Ferreira González <[email protected]> (cherry picked from commit 885878d)
11 tasks
MiguelCompany
pushed a commit
that referenced
this pull request
Dec 11, 2024
* Refs #22439. Fix Signed-off-by: Ricardo González Moreno <[email protected]> * Apply suggestions from code review Co-authored-by: Carlos Ferreira González <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]> Co-authored-by: Carlos Ferreira González <[email protected]> (cherry picked from commit 885878d) Co-authored-by: Ricardo González <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New feature
NetworkBuffers
brings this error. It is caused becauseboost::send_to
with multiple buffers has a maximum buffers. The hardcode value is 64.@Mergifyio backport 3.1.x 3.0.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist