Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22441] Improve Blackbox TCP tests suite #5467

Merged
merged 3 commits into from
Dec 10, 2024
Merged

[22441] Improve Blackbox TCP tests suite #5467

merged 3 commits into from
Dec 10, 2024

Conversation

cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented Dec 5, 2024 •
edited
Loading

Description

The Blackbox TCP tests are run twice, once with IPv4 and once with IPv6 configurations. However, some of the tests do not properly utilize this architecture feature, leading to duplicated test runs. This PR fixes those tests by leveraging the test architecture to avoid running the same tests twice and reducing the number of tests.

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@cferreiragonz cferreiragonz added needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels Dec 5, 2024
@cferreiragonz cferreiragonz added this to the v3.2.0 milestone Dec 5, 2024
@cferreiragonz cferreiragonz force-pushed the feature/improve_tcp_bb_tests branch from 41fac7f to 29315db Compare December 5, 2024 11:52
@cferreiragonz cferreiragonz requested review from richiprosima and removed request for richiprosima December 5, 2024 11:52
@cferreiragonz cferreiragonz removed the ci-pending PR which CI is running label Dec 9, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Dec 9, 2024
MiguelCompany
MiguelCompany approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@cferreiragonz cferreiragonz merged commit 0c799f4 into master Dec 10, 2024
17 checks passed
@cferreiragonz cferreiragonz deleted the feature/improve_tcp_bb_tests branch December 10, 2024 06:34
@cferreiragonz
Copy link
Contributor Author

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 10, 2024 •
edited
Loading

backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 10, 2024
@cferreiragonz @mergify
Improve Blackbox TCP tests suite (#5467)
8a3bc04 
* Refs #22441: Avoid running duplicated TCP tests

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22441: Avoid using parametrized test

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22441: Equal operator test

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
(cherry picked from commit 0c799f4)
@mergify mergify bot mentioned this pull request Dec 10, 2024
Merged
11 tasks
mergify bot pushed a commit that referenced this pull request Dec 10, 2024
@cferreiragonz @mergify
Improve Blackbox TCP tests suite (#5467)
72730d7 
* Refs #22441: Avoid running duplicated TCP tests

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22441: Avoid using parametrized test

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22441: Equal operator test

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
(cherry picked from commit 0c799f4)
mergify bot pushed a commit that referenced this pull request Dec 10, 2024
@cferreiragonz @mergify
Improve Blackbox TCP tests suite (#5467)
f1ea283 
* Refs #22441: Avoid running duplicated TCP tests

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22441: Avoid using parametrized test

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22441: Equal operator test

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
(cherry picked from commit 0c799f4)

# Conflicts:
#	test/blackbox/common/BlackboxTestsTransportTCP.cpp
This was referenced Dec 10, 2024
Open
Open
mergify bot pushed a commit that referenced this pull request Dec 10, 2024
@cferreiragonz @mergify
Improve Blackbox TCP tests suite (#5467)
4bad629 
* Refs #22441: Avoid running duplicated TCP tests

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22441: Avoid using parametrized test

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22441: Equal operator test

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
(cherry picked from commit 0c799f4)

# Conflicts:
#	test/blackbox/common/BlackboxTestsTransportTCP.cpp
mergify bot pushed a commit that referenced this pull request Dec 10, 2024
@cferreiragonz @mergify
Improve Blackbox TCP tests suite (#5467)
0e7ecfa 
* Refs #22441: Avoid running duplicated TCP tests

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22441: Avoid using parametrized test

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22441: Equal operator test

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
(cherry picked from commit 0c799f4)

# Conflicts:
#	test/blackbox/common/BlackboxTestsTransportTCP.cpp
This was referenced Dec 10, 2024
Open
Closed
MiguelCompany pushed a commit that referenced this pull request Dec 12, 2024
@mergify @cferreiragonz
Improve Blackbox TCP tests suite (#5467) (#5474)
79792d2 
* Refs #22441: Avoid running duplicated TCP tests

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22441: Avoid using parametrized test

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22441: Equal operator test

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
(cherry picked from commit 0c799f4)

Co-authored-by: Carlos Ferreira González <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running needs-review PR that is ready to be reviewed
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cferreiragonz @MiguelCompany