[22729] Flush logs in CliDiscoveryManager #5673
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR flushes the Logs in the destructor of the CliDiscoveryManager to ensure that all logs are processed before ending the application. This fixes the flaky test in Windows
test_fast_discovery_no_XML
in which, in some cases, the application was finishing before processing the Error logs, resulting in a false failed test.Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist