[20590] Feature: topic keys with non breaking ABI (iron backport) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
…rs_array in the parent messagemembers Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
MiguelCompany
requested changes
Mar 5, 2024
rosidl_typesupport_introspection_c/resource/msg__type_support.c.em
Outdated
Show resolved
Hide resolved
rosidl_typesupport_introspection_cpp/resource/msg__type_support.cpp.em
Outdated
Show resolved
Hide resolved
MiguelCompany
changed the title
Signed-off-by: Mario Dominguez <[email protected]>
MiguelCompany
approved these changes
Mar 6, 2024
Mario-DL
added a commit
that referenced
this pull request
Mar 7, 2024
* Refs #20156: Add is_key_ field to identify member as key Signed-off-by: Mario Dominguez <[email protected]> * Refs #20156: Add has_any_member_with_annotation() method for a struct Signed-off-by: Mario Dominguez <[email protected]> * Refs #20310: Define v2 ABI identifier Signed-off-by: Mario Dominguez <[email protected]> * Refs #20310: Update Message introspection with a new static key_members_array in the parent messagemembers Signed-off-by: Mario Dominguez <[email protected]> * Refs #20310: Review suggestions Signed-off-by: Mario Dominguez <[email protected]> * Refs #20310: NITs Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from #2 to
vulcanexus-iron