Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option search-path-linker to control linker options at build time #4697

Open
wants to merge 42 commits into
base: 5.0.x
Choose a base branch
from
Open

add option search-path-linker to control linker options at build time #4697

wants to merge 42 commits into from

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Nov 7, 2024

Follow-up to #4645.

Add option --search-path-linker to control how linker options are handled at build time

  • same approach used as for --search-path-cpp-headers
  • default behaviour does not change, we continue to use LDFLAGS
  • added option to use LIBRARY_PATH instead

lexming and others added 30 commits September 18, 2024 14:53
@lexming
add SearchPaths variable class for colon-separated lists of absolute …
1d1b882 
…paths
@lexming
add supported search paths by GNU CPP as toolchain variables
1d15f4d
@lexming
add build option cpp-headers-search-paths
841584f
@lexming
add toolchain option cpp-headers-search-paths
e3163ac
@lexming
add paths to headers from dependencies according to the option set in…
a82bee5 
… cpp-headers-search-path
@lexming
fix case where cpp-headers-search-path is set to None
20647b7
@lexming
rename CPP_HEADER_* globals to CPP_HEADERS_*
d8ab393
@lexming
simplify parsing of cpp-headers-search-path option values
079f202
@lexming
simplify FCC toolchain by using inheritance of new Toolchain._add_dep…
3493861 
…endency_cpp_headers method
@lexming
replace hardcoded variable settings in ACML with new Toolchain._add_d…
3b3e9d1 
…ependency_liker_paths and Toolchain._add_dependency_cpp_headers methods
@lexming
add test_cpp_headers_search_path to test.framework.toolchain
f0190f7
@lexming
rename cpp-headers-search-path option to search-path-cpp-headers
6471f17
@lexming
set default value of toolchain option search-path-cpp-headers to False
45514ef
@lexming
simplify search-path-cpp-headers option detection as its build option…
96b020e 
… cannot be None
@lexming
toolchain option search_path_ccp_headers can be None in unit tests
35db2f7
@lexming
build option search_path_ccp_headers can be None in unit tests
8cbb705
@lexming @Flamefire
avoid list conversion in test_search_path_cpp_headers
3daac79 
Co-authored-by: Alexander Grund <[email protected]>
@lexming @Flamefire
use None as default of toolchain option search-path-cpp-headers
a110459 
Co-authored-by: Alexander Grund <[email protected]>
@lexming
avoid warning about search-path-cpp-headers returning none
324c79c
@lexming
fix typo in comment of toolchain.prepare method
1344b97
@lexming
fix typo in docstring of toolchain._add_dependency_variables method
7e3b070
@lexming
remove duplicates with tools.utilities.nub instead of a set to preser…
77a65ad 
…ve order
@lexming @Flamefire
avoid list conversion in test_search_path_cpp_headers
80e5825 
Co-authored-by: Alexander Grund <[email protected]>
@lexming
handle extra_dirs passed as string and throw error for non-iterables
cd01b65
@lexming
import all of easybuild.tools.utilities with an alias in its test suite
d12251f
@lexming
add new emthod unique_ordered_append to easybuild.tools.utilities
b714e65
@lexming
simplify handling of search-path-cpp-headers option with tools.utilit…
e1ec9d9 
…ies.unique_ordered_append
@lexming @Flamefire
simplify error message in unique_ordered_append
d03ff29 
Co-authored-by: Alexander Grund <[email protected]>
@lexming @Flamefire
simplify error message in unique_ordered_append
ce18c9e 
Co-authored-by: Alexander Grund <[email protected]>
@lexming @Flamefire
simplify else codepath in unique_ordered_append
df086ae 
Co-authored-by: Alexander Grund <[email protected]>
@lexming lexming added this to the 5.0 milestone Nov 7, 2024
@lexming lexming changed the title add option --search-path-linker to control how linker options at build time add option --search-path-linker to control linker options at build time Nov 10, 2024
@lexming lexming changed the title add option --search-path-linker to control linker options at build time add option search-path-linker to control linker options at build time Nov 11, 2024
@boegel boegel added the EasyBuild-5.0 EasyBuild 5.0 label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
EasyBuild-5.0 EasyBuild 5.0 enhancement
Projects
EasyBuild v5.0
Status: Nice-to-have
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lexming @boegel