Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option search-path-linker to control linker options at build time #4697

Open
wants to merge 42 commits into
base: 5.0.x
Choose a base branch
from
Open

add option search-path-linker to control linker options at build time #4697

wants to merge 42 commits into from

Commits on Sep 18, 2024

  1. add SearchPaths variable class for colon-separated lists of absolute … 

    …paths
    @lexming
    lexming committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1d1b882 View commit details
    Browse the repository at this point in the history

  2. add supported search paths by GNU CPP as toolchain variables

    @lexming
    lexming committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1d15f4d View commit details
    Browse the repository at this point in the history

  3. add build option cpp-headers-search-paths

    @lexming
    lexming committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    841584f View commit details
    Browse the repository at this point in the history

  4. add toolchain option cpp-headers-search-paths

    @lexming
    lexming committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e3163ac View commit details
    Browse the repository at this point in the history

  5. add paths to headers from dependencies according to the option set in… 

    … cpp-headers-search-path
    @lexming
    lexming committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a82bee5 View commit details
    Browse the repository at this point in the history

  6. fix case where cpp-headers-search-path is set to None

    @lexming
    lexming committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    20647b7 View commit details
    Browse the repository at this point in the history

  7. rename CPP_HEADER_* globals to CPP_HEADERS_*

    @lexming
    lexming committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d8ab393 View commit details
    Browse the repository at this point in the history

  8. simplify parsing of cpp-headers-search-path option values

    @lexming
    lexming committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    079f202 View commit details
    Browse the repository at this point in the history

  9. simplify FCC toolchain by using inheritance of new Toolchain._add_dep… 

    …endency_cpp_headers method
    @lexming
    lexming committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3493861 View commit details
    Browse the repository at this point in the history

  10. replace hardcoded variable settings in ACML with new Toolchain._add_d… 

    …ependency_liker_paths and Toolchain._add_dependency_cpp_headers methods
    @lexming
    lexming committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3b3e9d1 View commit details
    Browse the repository at this point in the history

  11. add test_cpp_headers_search_path to test.framework.toolchain

    @lexming
    lexming committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f0190f7 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. rename cpp-headers-search-path option to search-path-cpp-headers

    @lexming
    lexming committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    6471f17 View commit details
    Browse the repository at this point in the history

  2. set default value of toolchain option search-path-cpp-headers to False

    @lexming
    lexming committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    45514ef View commit details
    Browse the repository at this point in the history

  3. simplify search-path-cpp-headers option detection as its build option… 

    … cannot be None
    @lexming
    lexming committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    96b020e View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. toolchain option search_path_ccp_headers can be None in unit tests

    @lexming
    lexming committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    35db2f7 View commit details
    Browse the repository at this point in the history

  2. build option search_path_ccp_headers can be None in unit tests

    @lexming
    lexming committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8cbb705 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. avoid list conversion in test_search_path_cpp_headers 

    Co-authored-by: Alexander Grund <[email protected]>
    @lexming @Flamefire
    lexming and Flamefire authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    3daac79 View commit details
    Browse the repository at this point in the history

  2. use None as default of toolchain option search-path-cpp-headers 

    Co-authored-by: Alexander Grund <[email protected]>
    @lexming @Flamefire
    lexming and Flamefire authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a110459 View commit details
    Browse the repository at this point in the history

  3. avoid warning about search-path-cpp-headers returning none

    @lexming
    lexming committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    324c79c View commit details
    Browse the repository at this point in the history

  4. fix typo in comment of toolchain.prepare method

    @lexming
    lexming committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    1344b97 View commit details
    Browse the repository at this point in the history

  5. fix typo in docstring of toolchain._add_dependency_variables method

    @lexming
    lexming committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    7e3b070 View commit details
    Browse the repository at this point in the history

  6. remove duplicates with tools.utilities.nub instead of a set to preser… 

    …ve order
    @lexming
    lexming committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    77a65ad View commit details
    Browse the repository at this point in the history

  7. avoid list conversion in test_search_path_cpp_headers 

    Co-authored-by: Alexander Grund <[email protected]>
    @lexming @Flamefire
    lexming and Flamefire authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    80e5825 View commit details
    Browse the repository at this point in the history

  8. handle extra_dirs passed as string and throw error for non-iterables

    @lexming
    lexming committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    cd01b65 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. import all of easybuild.tools.utilities with an alias in its test suite

    @lexming
    lexming committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d12251f View commit details
    Browse the repository at this point in the history

  2. add new emthod unique_ordered_append to easybuild.tools.utilities

    @lexming
    lexming committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b714e65 View commit details
    Browse the repository at this point in the history

  3. simplify handling of search-path-cpp-headers option with tools.utilit… 

    …ies.unique_ordered_append
    @lexming
    lexming committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e1ec9d9 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. simplify error message in unique_ordered_append 

    Co-authored-by: Alexander Grund <[email protected]>
    @lexming @Flamefire
    lexming and Flamefire authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    d03ff29 View commit details
    Browse the repository at this point in the history

  2. simplify error message in unique_ordered_append 

    Co-authored-by: Alexander Grund <[email protected]>
    @lexming @Flamefire
    lexming and Flamefire authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    ce18c9e View commit details
    Browse the repository at this point in the history

  3. simplify else codepath in unique_ordered_append 

    Co-authored-by: Alexander Grund <[email protected]>
    @lexming @Flamefire
    lexming and Flamefire authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    df086ae View commit details
    Browse the repository at this point in the history

  4. fix codestyle in unique_ordered_append

    @lexming
    lexming committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    4d1b56e View commit details
    Browse the repository at this point in the history

  5. rename unique_ordered_append to unique_ordered_extend and enforce clo… 

    …ser behaviour to extend
    @lexming
    lexming committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    c0662ae View commit details
    Browse the repository at this point in the history

  6. create local copy of base list in unique_ordered_extend

    @lexming
    lexming committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    485843d View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. add option --search-path-linker to control how linker options at buil… 

    …d time
    @lexming
    lexming committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    d62d108 View commit details
    Browse the repository at this point in the history

  2. add test_search_path_linker to test.framework.toolchain suite

    @lexming
    lexming committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    b413e09 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. fix codestyle in easybuild.tools.toolchain.toolchain

    @lexming
    lexming committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    5681192 View commit details
    Browse the repository at this point in the history

  2. simplify amount of globals declared for search-path-xxx toolchain opt… 

    …ions
    @lexming
    lexming committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    30a4ce9 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. avoid parsing search-path toolchain options more than once

    @lexming
    lexming committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    9f38c46 View commit details
    Browse the repository at this point in the history

  2. move validation of search path options earlier in toolchain prepare m… 

    …ethod
    @lexming
    lexming committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    47c71a3 View commit details
    Browse the repository at this point in the history

  3. update references in search path tests

    @lexming
    lexming committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    2d86f0d View commit details
    Browse the repository at this point in the history

  4. fix codestyle of SEARCH_PATH global definition

    @lexming
    lexming committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    2e61cee View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. fix removal of SYSTEM_TOOLCHAIN_NAME from easybuild.tools.options

    @lexming
    lexming committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    c4a66b6 View commit details
    Browse the repository at this point in the history