creation register unregister data races #45
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| bool CRegistrationProvider::RegisterProcess() | ||
| Registration::Sample CRegistrationProvider::GetProcessRegisterSample() |
There was a problem hiding this comment.
warning: method 'GetProcessRegisterSample' can be made static [readability-convert-member-functions-to-static]
ecal/core/src/registration/ecal_registration_provider.h:70:
- Registration::Sample GetProcessRegisterSample();
+ static Registration::Sample GetProcessRegisterSample();| } | ||
|
|
||
| bool CRegistrationProvider::UnregisterProcess() | ||
| Registration::Sample CRegistrationProvider::GetProcessUnregisterSample() |
There was a problem hiding this comment.
warning: method 'GetProcessUnregisterSample' can be made static [readability-convert-member-functions-to-static]
ecal/core/src/registration/ecal_registration_provider.h:71:
- Registration::Sample GetProcessUnregisterSample();
+ static Registration::Sample GetProcessUnregisterSample();
|
|
||
| bool CDescGate::GetServiceTypeNames(const std::string& service_name_, const std::string& method_name_, std::string& req_type_name_, std::string& resp_type_name_) | ||
| { | ||
| std::tuple<std::string, std::string> service_method_tuple = std::make_tuple(service_name_, method_name_); |
There was a problem hiding this comment.
warning: variable 'service_method_tuple' of type 'std::tuple<std::string, std::string>' (aka 'tuple<basic_string, basic_string>') can be declared 'const' [misc-const-correctness]
| std::tuple<std::string, std::string> service_method_tuple = std::make_tuple(service_name_, method_name_); | |
| std::tuple<std::string, std::string> const service_method_tuple = std::make_tuple(service_name_, method_name_); |
|
|
||
| bool CDescGate::GetServiceDescription(const std::string& service_name_, const std::string& method_name_, std::string& req_type_desc_, std::string& resp_type_desc_) | ||
| { | ||
| std::tuple<std::string, std::string> service_method_tuple = std::make_tuple(service_name_, method_name_); |
There was a problem hiding this comment.
warning: variable 'service_method_tuple' of type 'std::tuple<std::string, std::string>' (aka 'tuple<basic_string, basic_string>') can be declared 'const' [misc-const-correctness]
| std::tuple<std::string, std::string> service_method_tuple = std::make_tuple(service_name_, method_name_); | |
| std::tuple<std::string, std::string> const service_method_tuple = std::make_tuple(service_name_, method_name_); |
| } | ||
| } | ||
| break; | ||
| case bct_unreg_service: |
There was a problem hiding this comment.
warning: switch has 3 consecutive identical branches [bugprone-branch-clone]
case bct_unreg_service:
^Additional context
ecal/core/src/ecal_descgate.cpp:211: last of these clones ends here
break;
^|
|
||
| Registration::Sample CRegistrationProvider::GetProcessRegisterSample() |
There was a problem hiding this comment.
warning: method 'GetProcessRegisterSample' can be made static [readability-convert-member-functions-to-static]
ecal/core/src/registration/ecal_registration_provider.h:74:
- Registration::Sample GetProcessRegisterSample();
+ static Registration::Sample GetProcessRegisterSample();| } | ||
|
|
||
| bool CRegistrationProvider::RegisterClient() | ||
| Registration::Sample CRegistrationProvider::GetProcessUnregisterSample() |
There was a problem hiding this comment.
warning: method 'GetProcessUnregisterSample' can be made static [readability-convert-member-functions-to-static]
ecal/core/src/registration/ecal_registration_provider.h:75:
- Registration::Sample GetProcessUnregisterSample();
+ static Registration::Sample GetProcessUnregisterSample();
| } | ||
| } | ||
| break; | ||
| case bct_unreg_service: |
There was a problem hiding this comment.
warning: switch has 3 consecutive identical branches [bugprone-branch-clone]
case bct_unreg_service:
^Additional context
ecal/core/src/ecal_descgate.cpp:196: last of these clones ends here
break;
^| , const SDataTypeInformation& request_type_information_ | ||
| , const SDataTypeInformation& response_type_information_) | ||
| { | ||
| std::tuple<std::string, std::string> service_method_tuple = std::make_tuple(service_name_, method_name_); |
There was a problem hiding this comment.
warning: variable 'service_method_tuple' of type 'std::tuple<std::string, std::string>' (aka 'tuple<basic_string, basic_string>') can be declared 'const' [misc-const-correctness]
| std::tuple<std::string, std::string> service_method_tuple = std::make_tuple(service_name_, method_name_); | |
| std::tuple<std::string, std::string> const service_method_tuple = std::make_tuple(service_name_, method_name_); |
| } | ||
| } | ||
| break; | ||
| case bct_unreg_service: |
There was a problem hiding this comment.
warning: switch has 3 consecutive identical branches [bugprone-branch-clone]
case bct_unreg_service:
^Additional context
ecal/core/src/ecal_descgate.cpp:241: last of these clones ends here
break;
^
No description provided.