[core] active entity unregistration in descgate #1520

rex-schilasky · 2024-04-10T15:25:16Z

Description

DescGate is currently collecting descriptions (type encodings, type names, type descriptors) for publisher, subscriber and services.

This PR:

extends it to collect descriptions for clients too
introduces active removal of descriptions triggered by unregistration events, this will lead to faster removal
improves quality logic by separate quality for service request and response data info types
utilize the pub/sub/server/client id's to not merge/overwrite description in the DescGate but keep them separately

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 20 out of 26. Check the log or trigger a new build to see more.

github-actions · 2024-04-10T15:38:34Z

ecal/core/src/ecal_descgate.cpp

+    const auto topic_info_it = m_topic_info_map.map->find(topic_name_);
+    if (topic_info_it != m_topic_info_map.map->end())
+    {
+      STopicInfoQuality& topic_info = (*m_topic_info_map.map)[topic_name_];


warning: variable 'topic_info' of type 'STopicInfoQuality &' can be declared 'const' [misc-const-correctness]

Suggested change

STopicInfoQuality& topic_info = (*m_topic_info_map.map)[topic_name_];

STopicInfoQuality const& topic_info = (*m_topic_info_map.map)[topic_name_];

github-actions · 2024-04-10T15:38:34Z

ecal/core/src/ecal_descgate.cpp

+    return false;
+  }
+
+  bool CDescGate::ApplyServiceDescription(SServiceMethodInfoMap& service_method_map_


warning: method 'ApplyServiceDescription' can be made static [readability-convert-member-functions-to-static]

ecal/core/src/ecal_descgate.h:136:

- bool ApplyServiceDescription(SServiceMethodInfoMap& service_method_map_, + static bool ApplyServiceDescription(SServiceMethodInfoMap& service_method_map_,

github-actions · 2024-04-10T15:38:34Z

ecal/core/src/ecal_descgate.cpp

+    return false;
+  }
+
+  bool CDescGate::RemServiceDescription(SServiceMethodInfoMap& service_method_map_, const std::string& service_name_, const std::string& service_id_)


warning: method 'RemServiceDescription' can be made static [readability-convert-member-functions-to-static]

ecal/core/src/ecal_descgate.h:144:

- bool RemServiceDescription(SServiceMethodInfoMap& service_method_map_, + static bool RemServiceDescription(SServiceMethodInfoMap& service_method_map_,

github-actions · 2024-04-10T15:38:34Z

ecal/core/src/ecal_descgate.cpp

+    return success;
+  }
+
+  void CDescGate::GetServices(std::map<std::tuple<std::string, std::string>, SServiceMethodInformation>& service_info_map_, const SServiceMethodInfoMap& service_method_map_)


warning: method 'GetServices' can be made static [readability-convert-member-functions-to-static]

ecal/core/src/ecal_descgate.h:148:

- void GetServices(std::map<std::tuple<std::string, std::string>, SServiceMethodInformation>& service_info_map_, const SServiceMethodInfoMap& service_method_map_); + static void GetServices(std::map<std::tuple<std::string, std::string>, SServiceMethodInformation>& service_info_map_, const SServiceMethodInfoMap& service_method_map_);

github-actions · 2024-04-10T15:38:35Z

ecal/core/src/ecal_descgate.cpp

+    service_info_map_.swap(map);
+  }
+
+  void CDescGate::GetServiceMethodNames(std::vector<std::tuple<std::string, std::string>>& method_names_, const SServiceMethodInfoMap& service_method_map_)


warning: method 'GetServiceMethodNames' can be made static [readability-convert-member-functions-to-static]

ecal/core/src/ecal_descgate.h:149:

- void GetServiceMethodNames(std::vector<std::tuple<std::string, std::string>>& method_names_, const SServiceMethodInfoMap& service_method_map_); + static void GetServiceMethodNames(std::vector<std::tuple<std::string, std::string>>& method_names_, const SServiceMethodInfoMap& service_method_map_);

github-actions · 2024-04-10T15:38:35Z

ecal/tests/cpp/expmap_test/src/expmap_test.cpp

@@ -125,7 +125,7 @@
 }

 // This test assures that find can be called on a const CExpMap and returns an CExpMap::const_iterator
-TEST(core_cpp_util, ExpMap_FindConst)
+TEST(core_cpp_core, ExpMap_FindConst)


warning: all parameters should be named in a function [readability-named-parameter]

Suggested change

TEST(core_cpp_core, ExpMap_FindConst)

TEST(core_cpp_core /*unused*/, ExpMap_FindConst /*unused*/)

github-actions · 2024-04-10T15:38:35Z

ecal/tests/cpp/expmap_test/src/expmap_test.cpp

@@ -146,7 +146,7 @@
  EXPECT_EQ(0, expmap.size());
 }

-TEST(core_cpp_util, ExpMap_Iterate)
+TEST(core_cpp_core, ExpMap_Iterate)


warning: all parameters should be named in a function [readability-named-parameter]

Suggested change

TEST(core_cpp_core, ExpMap_Iterate)

TEST(core_cpp_core /*unused*/, ExpMap_Iterate /*unused*/)

github-actions · 2024-04-10T15:38:36Z

ecal/tests/cpp/expmap_test/src/expmap_test.cpp

@@ -180,7 +180,7 @@
  EXPECT_EQ(1, value);
 }

-TEST(core_cpp_util, ExpMap_ConstExpMapIterate)
+TEST(core_cpp_core, ExpMap_ConstExpMapIterate)


warning: all parameters should be named in a function [readability-named-parameter]

Suggested change

TEST(core_cpp_core, ExpMap_ConstExpMapIterate)

TEST(core_cpp_core /*unused*/, ExpMap_ConstExpMapIterate /*unused*/)

github-actions · 2024-04-10T15:38:36Z

ecal/tests/cpp/expmap_test/src/expmap_test.cpp

@@ -189,23 +189,23 @@
  ConstRefIterate(expmap);
 }

-TEST(core_cpp_util, ExpMap_Empty)
+TEST(core_cpp_core, ExpMap_Empty)


warning: all parameters should be named in a function [readability-named-parameter]

Suggested change

TEST(core_cpp_core, ExpMap_Empty)

TEST(core_cpp_core /*unused*/, ExpMap_Empty /*unused*/)

github-actions · 2024-04-10T15:38:36Z

ecal/tests/cpp/expmap_test/src/expmap_test.cpp

 {
  eCAL::Util::CExpMap<std::string, int> expmap(std::chrono::milliseconds(200));
  EXPECT_EQ(true, expmap.empty());
  expmap["A"] = 1;
  EXPECT_EQ(false, expmap.empty());
 }

-TEST(core_cpp_util, ExpMap_Size)
+TEST(core_cpp_core, ExpMap_Size)


warning: all parameters should be named in a function [readability-named-parameter]

Suggested change

TEST(core_cpp_core, ExpMap_Size)

TEST(core_cpp_core /*unused*/, ExpMap_Size /*unused*/)

ecal_util started to adapt

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 20 out of 22. Check the log or trigger a new build to see more.

github-actions · 2024-04-12T15:15:01Z

ecal/core/include/ecal/ecal_util.h

+     *
+     * @param topic_info_map_  Map to store the qualified datatype information.
+    **/
+    ECAL_API void GetTopics(std::unordered_map<std::string, SQualityDataTypeInformation>& qualfied_data_type_info_map_);


warning: function 'eCAL::Util::GetTopics' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]

ECAL_API void GetTopics(std::unordered_map<std::string, SQualityDataTypeInformation>& qualfied_data_type_info_map_); ^

Additional context

ecal/core/src/ecal_util.cpp:330: the definition seen here

void GetTopics(std::unordered_map<std::string, SQualityDataTypeInformation>& qualified_data_type_info_map_) ^

ecal/core/include/ecal/ecal_util.h:226: differing parameters are named here: ('qualfied_data_type_info_map_'), in definition: ('qualified_data_type_info_map_')

ECAL_API void GetTopics(std::unordered_map<std::string, SQualityDataTypeInformation>& qualfied_data_type_info_map_); ^

github-actions · 2024-04-12T15:15:02Z

ecal/core/src/ecal_descgate.cpp

  }

-  void CDescGate::GetServiceNames(std::vector<std::tuple<std::string, std::string>>& service_method_names_)
+  CDescGate::TopicNameIdMap CDescGate::GetTopics(const STopicInfoMap& topic_map_)


warning: method 'GetTopics' can be made static [readability-convert-member-functions-to-static]

ecal/core/src/ecal_descgate.h:98:

- TopicNameIdMap GetTopics(const STopicInfoMap& topic_map_); + static TopicNameIdMap GetTopics(const STopicInfoMap& topic_map_);

github-actions · 2024-04-12T15:15:02Z

ecal/core/src/ecal_descgate.cpp

-  }
-
-  bool CDescGate::GetServiceDescription(const std::string& service_name_, const std::string& method_name_, std::string& req_type_desc_, std::string& resp_type_desc_)
+  CDescGate::ServiceMethodNameIdMap CDescGate::GetServices(const SServiceMethodInfoMap& service_method_info_map_)


warning: method 'GetServices' can be made static [readability-convert-member-functions-to-static]

ecal/core/src/ecal_descgate.h:113:

- ServiceMethodNameIdMap GetServices(const SServiceMethodInfoMap& service_method_info_map_); + static ServiceMethodNameIdMap GetServices(const SServiceMethodInfoMap& service_method_info_map_);

github-actions · 2024-04-12T15:15:02Z

ecal/core/src/ecal_descgate.cpp

  }

-  bool CDescGate::ApplyTopicDescription(const std::string& topic_name_, const SDataTypeInformation& topic_info_, const QualityFlags description_quality_)
+  void CDescGate::ApplyTopicDescription(STopicInfoMap& topic_info_map_,


warning: method 'ApplyTopicDescription' can be made static [readability-convert-member-functions-to-static]

ecal/core/src/ecal_descgate.h:117:

- void ApplyTopicDescription(STopicInfoMap& topic_info_map_, + static void ApplyTopicDescription(STopicInfoMap& topic_info_map_,

github-actions · 2024-04-12T15:15:02Z

ecal/core/src/ecal_descgate.cpp

-    // topic type name or topic description differ and this is not logged yet
-    // so we log the error and update the entry one time
-    bool update_topic_info(false);
+    const auto topic_info_it = topic_info_map_.map->find(topic_info_key);


warning: Value stored to 'topic_info_it' during its initialization is never read [clang-analyzer-deadcode.DeadStores]

const auto topic_info_it = topic_info_map_.map->find(topic_info_key); ^

Additional context

ecal/core/src/ecal_descgate.cpp:228: Value stored to 'topic_info_it' during its initialization is never read

const auto topic_info_it = topic_info_map_.map->find(topic_info_key); ^

github-actions · 2024-04-12T15:15:03Z

ecal/core/src/ecal_util.cpp

+    {
+      std::vector<SQualityServiceMethodInformation> service_method_info_vec = GetServiceTypeInformation(client_name_, method_name_, GetClients());
+
+      SServiceMethodInformation service_method_info = GetHighestQualifiedServiceMethodInformation(service_method_info_vec);


warning: variable 'service_method_info' of type 'SServiceMethodInformation' can be declared 'const' [misc-const-correctness]

Suggested change

SServiceMethodInformation service_method_info = GetHighestQualifiedServiceMethodInformation(service_method_info_vec);

SServiceMethodInformation const service_method_info = GetHighestQualifiedServiceMethodInformation(service_method_info_vec);

github-actions · 2024-04-12T15:15:03Z

ecal/tests/cpp/expmap_test/src/expmap_test.cpp

 {
  eCAL::Util::CExpMap<std::string, int> expmap(std::chrono::milliseconds(200));
  EXPECT_EQ(0, expmap.size());
  expmap["A"] = 1;
  EXPECT_EQ(1, expmap.size());
 }

-TEST(core_cpp_util, ExpMap_Remove)
+TEST(core_cpp_core, ExpMap_Remove)


warning: all parameters should be named in a function [readability-named-parameter]

Suggested change

TEST(core_cpp_core, ExpMap_Remove)

TEST(core_cpp_core /*unused*/, ExpMap_Remove /*unused*/)

github-actions · 2024-04-12T15:15:03Z

ecal/tests/cpp/util_test/src/util_getclients.cpp

+#include <ecal/ecal.h>
+#include <ecal/ecal_types.h>
+
+#include <gtest/gtest.h>


warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]

#include <gtest/gtest.h> ^

github-actions · 2024-04-12T15:15:03Z

ecal/tests/cpp/util_test/src/util_getclients.cpp

+#define CMN_REGISTRATION_REFRESH 1000
+#define CMN_MONITORING_TIMEOUT   5000
+


warning: replace macro with enum [modernize-macro-to-enum]

Suggested change

#define CMN_REGISTRATION_REFRESH 1000

#define CMN_MONITORING_TIMEOUT 5000

enum {

CMN_REGISTRATION_REFRESH = 1000,

CMN_MONITORING_TIMEOUT = 5000};

github-actions · 2024-04-12T15:15:03Z

ecal/tests/cpp/util_test/src/util_getclients.cpp

+
+#include <gtest/gtest.h>
+
+#define CMN_REGISTRATION_REFRESH 1000


warning: macro 'CMN_REGISTRATION_REFRESH' defines an integral constant; prefer an enum instead [modernize-macro-to-enum]

#define CMN_REGISTRATION_REFRESH 1000 ^

github-actions

clang-tidy made some suggestions

github-actions · 2024-04-12T16:07:54Z

ecal/tests/cpp/util_test/src/util_getclients.cpp

+#include <gtest/gtest.h>
+
+#define CMN_REGISTRATION_REFRESH 1000
+#define CMN_MONITORING_TIMEOUT   5000


warning: macro 'CMN_MONITORING_TIMEOUT' defines an integral constant; prefer an enum instead [modernize-macro-to-enum]

#define CMN_MONITORING_TIMEOUT 5000 ^

github-actions · 2024-04-12T16:07:54Z

ecal/tests/cpp/util_test/src/util_getclients.cpp

+#define CMN_REGISTRATION_REFRESH 1000
+#define CMN_MONITORING_TIMEOUT   5000
+
+TEST(core_cpp_util, GetClients)


warning: variable 'TEST' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

TEST(core_cpp_util, GetClients) ^

github-actions

clang-tidy made some suggestions

github-actions · 2024-04-12T20:33:16Z

ecal/core/include/ecal/ecal_util.h

+     * @param qualfied_data_type_info_map_  Map to store the qualified datatype information.
+     *                                      Map { TopicName -> SQualityDataTypeInformation } mapping of all currently known publisher/subscriber.
+    **/
+    ECAL_API void GetTopics(std::unordered_map<std::string, SQualityDataTypeInformation>& qualfied_data_type_info_map_);


warning: function 'eCAL::Util::GetTopics' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]

ECAL_API void GetTopics(std::unordered_map<std::string, SQualityDataTypeInformation>& qualfied_data_type_info_map_); ^

Additional context

ecal/core/src/ecal_util.cpp:332: the definition seen here

void GetTopics(std::unordered_map<std::string, SQualityDataTypeInformation>& qualified_data_type_info_map_) ^

ecal/core/include/ecal/ecal_util.h:228: differing parameters are named here: ('qualfied_data_type_info_map_'), in definition: ('qualified_data_type_info_map_')

ECAL_API void GetTopics(std::unordered_map<std::string, SQualityDataTypeInformation>& qualfied_data_type_info_map_); ^

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 20 out of 21. Check the log or trigger a new build to see more.

github-actions · 2024-04-14T21:11:38Z

ecal/core/include/ecal/ecal_util.h

+     *
+     * @return Highest quality data type information.
+    **/
+    ECAL_API SDataTypeInformation GetHighestQualityDataTypeInformation(const std::vector<SQualityTopicInfo>& data_type_info_vec_);


warning: function 'eCAL::Util::GetHighestQualityDataTypeInformation' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]

ECAL_API SDataTypeInformation GetHighestQualityDataTypeInformation(const std::vector<SQualityTopicInfo>& data_type_info_vec_); ^

Additional context

ecal/core/src/ecal_util.cpp:327: the definition seen here

SDataTypeInformation GetHighestQualityDataTypeInformation(const std::vector<SQualityTopicInfo>& quality_topic_info_vec_) ^

ecal/core/include/ecal/ecal_util.h:188: differing parameters are named here: ('data_type_info_vec_'), in definition: ('quality_topic_info_vec_')

ECAL_API SDataTypeInformation GetHighestQualityDataTypeInformation(const std::vector<SQualityTopicInfo>& data_type_info_vec_); ^

github-actions · 2024-04-14T21:11:38Z

ecal/core/include/ecal/ecal_util.h

+     *
+     * @return Highest quality service method information.
+    **/
+    ECAL_API SServiceMethodInformation GetHighestQualityServiceMethodInformation(const std::vector<SQualityServiceInfo>& service_method_info_vec_);


warning: function 'eCAL::Util::GetHighestQualityServiceMethodInformation' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]

ECAL_API SServiceMethodInformation GetHighestQualityServiceMethodInformation(const std::vector<SQualityServiceInfo>& service_method_info_vec_); ^

Additional context

ecal/core/src/ecal_util.cpp:367: the definition seen here

SServiceMethodInformation GetHighestQualityServiceMethodInformation(const std::vector<SQualityServiceInfo>& quality_service_info_vec_) ^

ecal/core/include/ecal/ecal_util.h:211: differing parameters are named here: ('service_method_info_vec_'), in definition: ('quality_service_info_vec_')

ECAL_API SServiceMethodInformation GetHighestQualityServiceMethodInformation(const std::vector<SQualityServiceInfo>& service_method_info_vec_); ^

github-actions · 2024-04-14T21:11:38Z

ecal/core/include/ecal/ecal_util.h

+     * @param quality_data_type_info_map_  Map to store the quality datatype information.
+     *                                     Map { TopicName -> SQualityDataTypeInformation } mapping of all currently known publisher/subscriber.
+    **/
+    ECAL_API void GetTopics(std::map<std::string, SQualityTopicInfo>& quality_data_type_info_map_);


warning: function 'eCAL::Util::GetTopics' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]

ECAL_API void GetTopics(std::map<std::string, SQualityTopicInfo>& quality_data_type_info_map_); ^

Additional context

ecal/core/src/ecal_util.cpp:394: the definition seen here

void GetTopics(std::map<std::string, SQualityTopicInfo>& quality_topic_info_map_) ^

ecal/core/include/ecal/ecal_util.h:227: differing parameters are named here: ('quality_data_type_info_map_'), in definition: ('quality_topic_info_map_')

ECAL_API void GetTopics(std::map<std::string, SQualityTopicInfo>& quality_data_type_info_map_); ^

github-actions · 2024-04-14T21:11:38Z

ecal/core/include/ecal/ecal_util.h

@@ -149,19 +245,27 @@
    ECAL_API bool GetTopicDataTypeInformation(const std::string& topic_name_, SDataTypeInformation& topic_info_);


warning: function 'eCAL::Util::GetTopicDataTypeInformation' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]

ECAL_API bool GetTopicDataTypeInformation(const std::string& topic_name_, SDataTypeInformation& topic_info_); ^

Additional context

ecal/core/src/ecal_util.cpp:430: the definition seen here

bool GetTopicDataTypeInformation(const std::string& topic_name_, SDataTypeInformation& data_type_info_) ^

ecal/core/include/ecal/ecal_util.h:244: differing parameters are named here: ('topic_info_'), in definition: ('data_type_info_')

ECAL_API bool GetTopicDataTypeInformation(const std::string& topic_name_, SDataTypeInformation& topic_info_); ^

github-actions · 2024-04-14T21:11:38Z

ecal/core/include/ecal/ecal_util.h

+     * @param service_info_map_  Map to store the service/method descriptions.
+     *                           Map { (ServiceName, MethodName) -> SServiceMethodInformation } mapping of all currently known services.
+    **/
+      ECAL_API void GetServices(std::map<std::tuple<std::string, std::string>, SServiceMethodInformation>& service_info_map_);


warning: function 'eCAL::Util::GetServices' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]

ECAL_API void GetServices(std::map<std::tuple<std::string, std::string>, SServiceMethodInformation>& service_info_map_); ^

Additional context

ecal/core/src/ecal_util.cpp:441: the definition seen here

void GetServices(std::map<std::tuple<std::string, std::string>, SServiceMethodInformation>& service_method_info_map_) ^

ecal/core/include/ecal/ecal_util.h:252: differing parameters are named here: ('service_info_map_'), in definition: ('service_method_info_map_')

ECAL_API void GetServices(std::map<std::tuple<std::string, std::string>, SServiceMethodInformation>& service_info_map_); ^

github-actions · 2024-04-14T21:11:39Z

ecal/core/src/ecal_util.cpp

    }

    bool GetServiceDescription(const std::string& service_name_, const std::string& method_name_, std::string& req_desc_, std::string& resp_desc_)
    {
-      if (g_descgate() == nullptr) return(false);
-      return(g_descgate()->GetServiceDescription(service_name_, method_name_, req_desc_, resp_desc_));
+      std::vector<SQualityServiceInfo> service_method_info_vec = GetQualityServiceInfoVec(service_name_, method_name_, GetServices());


warning: variable 'service_method_info_vec' of type 'std::vector' can be declared 'const' [misc-const-correctness]

Suggested change

std::vector<SQualityServiceInfo> service_method_info_vec = GetQualityServiceInfoVec(service_name_, method_name_, GetServices());

std::vector<SQualityServiceInfo> const service_method_info_vec = GetQualityServiceInfoVec(service_name_, method_name_, GetServices());

github-actions · 2024-04-14T21:11:39Z

ecal/core/src/ecal_util.cpp

-      return(g_descgate()->GetServiceDescription(service_name_, method_name_, req_desc_, resp_desc_));
+      std::vector<SQualityServiceInfo> service_method_info_vec = GetQualityServiceInfoVec(service_name_, method_name_, GetServices());
+
+      SServiceMethodInformation service_method_info = GetHighestQualityServiceMethodInformation(service_method_info_vec);


warning: variable 'service_method_info' of type 'SServiceMethodInformation' can be declared 'const' [misc-const-correctness]

Suggested change

SServiceMethodInformation service_method_info = GetHighestQualityServiceMethodInformation(service_method_info_vec);

SServiceMethodInformation const service_method_info = GetHighestQualityServiceMethodInformation(service_method_info_vec);

github-actions · 2024-04-14T21:11:39Z

ecal/core/src/ecal_util.cpp

+
+    bool GetClientTypeNames(const std::string& client_name_, const std::string& method_name_, std::string& req_type_, std::string& resp_type_)
+    {
+      std::vector<SQualityServiceInfo> service_method_info_vec = GetQualityServiceInfoVec(client_name_, method_name_, GetClients());


warning: variable 'service_method_info_vec' of type 'std::vector' can be declared 'const' [misc-const-correctness]

Suggested change

std::vector<SQualityServiceInfo> service_method_info_vec = GetQualityServiceInfoVec(client_name_, method_name_, GetClients());

std::vector<SQualityServiceInfo> const service_method_info_vec = GetQualityServiceInfoVec(client_name_, method_name_, GetClients());

github-actions · 2024-04-14T21:11:39Z

ecal/core/src/ecal_util.cpp

+    {
+      std::vector<SQualityServiceInfo> service_method_info_vec = GetQualityServiceInfoVec(client_name_, method_name_, GetClients());
+
+      SServiceMethodInformation service_method_info = GetHighestQualityServiceMethodInformation(service_method_info_vec);


warning: variable 'service_method_info' of type 'SServiceMethodInformation' can be declared 'const' [misc-const-correctness]

Suggested change

SServiceMethodInformation service_method_info = GetHighestQualityServiceMethodInformation(service_method_info_vec);

SServiceMethodInformation const service_method_info = GetHighestQualityServiceMethodInformation(service_method_info_vec);

github-actions · 2024-04-14T21:11:39Z

ecal/core/src/ecal_util.cpp

+
+    bool GetClientDescription(const std::string& client_name_, const std::string& method_name_, std::string& req_desc_, std::string& resp_desc_)
+    {
+      std::vector<SQualityServiceInfo> service_method_info_vec = GetQualityServiceInfoVec(client_name_, method_name_, GetClients());


warning: variable 'service_method_info_vec' of type 'std::vector' can be declared 'const' [misc-const-correctness]

Suggested change

std::vector<SQualityServiceInfo> service_method_info_vec = GetQualityServiceInfoVec(client_name_, method_name_, GetClients());

std::vector<SQualityServiceInfo> const service_method_info_vec = GetQualityServiceInfoVec(client_name_, method_name_, GetClients());

github-actions

clang-tidy made some suggestions

github-actions · 2024-04-14T21:47:39Z

ecal/core/src/ecal_util.cpp

+    {
+      std::vector<SQualityServiceInfo> service_method_info_vec = GetQualityServiceInfoVec(client_name_, method_name_, GetClients());
+
+      SServiceMethodInformation service_method_info = GetHighestQualityServiceMethodInformation(service_method_info_vec);


warning: variable 'service_method_info' of type 'SServiceMethodInformation' can be declared 'const' [misc-const-correctness]

Suggested change

SServiceMethodInformation service_method_info = GetHighestQualityServiceMethodInformation(service_method_info_vec);

SServiceMethodInformation const service_method_info = GetHighestQualityServiceMethodInformation(service_method_info_vec);

util test, getservices, getclients started to refactor

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 20 out of 39. Check the log or trigger a new build to see more.

github-actions · 2024-04-15T12:06:18Z

ecal/core/src/ecal_descgate.cpp

-    , const SDataTypeInformation& request_type_information_
-    , const SDataTypeInformation& response_type_information_
-    , const QualityFlags description_quality_)
+  void CDescGate::RemServiceDescription(SQualityServiceIdMap& service_method_info_map_, const std::string& service_name_, const std::string& service_id_)


warning: method 'RemServiceDescription' can be made static [readability-convert-member-functions-to-static]

ecal/core/src/ecal_descgate.h:145:

- void RemServiceDescription(SQualityServiceIdMap& service_method_info_map_, + static void RemServiceDescription(SQualityServiceIdMap& service_method_info_map_,

github-actions · 2024-04-15T12:06:18Z

ecal/core/src/ecal_descgate.h

+                               const std::string& topic_name_,
+                               const std::string& topic_id_,
+                               const SDataTypeInformation& topic_info_,
+                               const Util::DescQualityFlags topic_quality_);


warning: parameter 'topic_quality_' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]

Suggested change

const Util::DescQualityFlags topic_quality_);

Util::DescQualityFlags topic_quality_);

github-actions · 2024-04-15T12:06:18Z

ecal/core/src/ecal_descgate.h

+                                 const std::string& method_name_,
+                                 const SDataTypeInformation& request_type_information_,
+                                 const SDataTypeInformation& response_type_information_,
+                                 const Util::DescQualityFlags request_type_quality_,


warning: parameter 'request_type_quality_' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]

Suggested change

const Util::DescQualityFlags request_type_quality_,

Util::DescQualityFlags request_type_quality_,

github-actions · 2024-04-15T12:06:18Z

ecal/core/src/ecal_descgate.h

+                                 const SDataTypeInformation& request_type_information_,
+                                 const SDataTypeInformation& response_type_information_,
+                                 const Util::DescQualityFlags request_type_quality_,
+                                 const Util::DescQualityFlags response_type_quality_);


warning: parameter 'response_type_quality_' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]

Suggested change

const Util::DescQualityFlags response_type_quality_);

Util::DescQualityFlags response_type_quality_);

github-actions · 2024-04-15T12:06:18Z

ecal/tests/cpp/util_test/src/util_getclients.cpp

+#define CMN_MONITORING_TIMEOUT 5000
+


warning: replace macro with enum [modernize-macro-to-enum]

Suggested change

#define CMN_MONITORING_TIMEOUT 5000

enum {

CMN_MONITORING_TIMEOUT = 5000};

github-actions · 2024-04-15T12:06:19Z

ecal/tests/cpp/util_test/src/util_getclients.cpp

+  eCAL::Finalize();
+}
+
+TEST(core_cpp_util, ClientDifferentQualities)


warning: all parameters should be named in a function [readability-named-parameter]

Suggested change

TEST(core_cpp_util, ClientDifferentQualities)

TEST(core_cpp_util /*unused*/, ClientDifferentQualities /*unused*/)

github-actions · 2024-04-15T12:06:19Z

ecal/tests/cpp/util_test/src/util_getclients.cpp

+  // initialize eCAL API
+  eCAL::Initialize(0, nullptr, "core_cpp_util");
+
+  std::map<std::tuple<std::string, std::string>, eCAL::SServiceMethodInformation> client_info_map;


warning: variable 'client_info_map' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::map<std::tuple<std::string, std::string>, eCAL::SServiceMethodInformation> client_info_map;

std::map<std::tuple<std::string, std::string>, eCAL::SServiceMethodInformation> client_info_map = 0;

github-actions · 2024-04-15T12:06:19Z

ecal/tests/cpp/util_test/src/util_getclients.cpp

+    EXPECT_EQ(client_info_map.size(), 1);
+
+    // check attributes
+    std::string req_type, resp_type;


warning: variable 'req_type' of type 'std::string' (aka 'basic_string') can be declared 'const' [misc-const-correctness]

std::string req_type, resp_type; ^

github-actions · 2024-04-15T12:06:19Z

ecal/tests/cpp/util_test/src/util_getclients.cpp

+    EXPECT_EQ(client_info_map.size(), 1);
+
+    // check attributes
+    std::string req_type, resp_type;


warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration]

Suggested change

std::string req_type, resp_type;

std::string req_type;

std::string resp_type;

github-actions · 2024-04-15T12:06:20Z

ecal/tests/cpp/util_test/src/util_getclients.cpp

+
+    // check attributes
+    std::string req_type, resp_type;
+    std::string req_desc, resp_desc;


warning: variable 'req_desc' of type 'std::string' (aka 'basic_string') can be declared 'const' [misc-const-correctness]

std::string req_desc, resp_desc; ^

github-actions

clang-tidy made some suggestions

github-actions · 2024-04-15T13:08:02Z

ecal/tests/cpp/util_test/src/util_getclients.cpp

+
+    // check attributes
+    std::string req_type, resp_type;
+    std::string req_desc, resp_desc;


warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration]

Suggested change

std::string req_desc, resp_desc;

std::string req_desc;

std::string resp_desc;

github-actions · 2024-04-15T13:08:02Z

ecal/tests/cpp/util_test/src/util_getservices.cpp

+#include <ecal/ecal.h>
+#include <ecal/ecal_types.h>
+
+#include <gtest/gtest.h>


warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]

#include <gtest/gtest.h> ^

github-actions · 2024-04-15T13:08:02Z

ecal/tests/cpp/util_test/src/util_getservices.cpp

+
+enum { CMN_MONITORING_TIMEOUT = 5000 };
+
+TEST(core_cpp_util, ServiceExpiration)


warning: all parameters should be named in a function [readability-named-parameter]

Suggested change

TEST(core_cpp_util, ServiceExpiration)

TEST(core_cpp_util /*unused*/, ServiceExpiration /*unused*/)

github-actions · 2024-04-15T13:08:02Z

ecal/tests/cpp/util_test/src/util_getservices.cpp

+  // initialize eCAL API
+  eCAL::Initialize(0, nullptr, "core_cpp_util");
+
+  std::map<std::tuple<std::string, std::string>, eCAL::SServiceMethodInformation> service_info_map;


warning: variable 'service_info_map' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::map<std::tuple<std::string, std::string>, eCAL::SServiceMethodInformation> service_info_map;

std::map<std::tuple<std::string, std::string>, eCAL::SServiceMethodInformation> service_info_map = 0;

github-actions · 2024-04-15T13:08:02Z

ecal/tests/cpp/util_test/src/util_getservices.cpp

+    EXPECT_EQ(service_info_map.size(), 1);
+
+    // check service/method names
+    std::vector<std::tuple<std::string, std::string>> service_method_names;


warning: variable 'service_method_names' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::vector<std::tuple<std::string, std::string>> service_method_names;

std::vector<std::tuple<std::string, std::string>> service_method_names = 0;

github-actions · 2024-04-15T13:08:03Z

ecal/tests/cpp/util_test/src/util_getservices.cpp

+  // initialize eCAL API
+  eCAL::Initialize(0, nullptr, "core_cpp_util");
+
+  std::map<std::tuple<std::string, std::string>, eCAL::SServiceMethodInformation> service_info_map;


warning: variable 'service_info_map' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::map<std::tuple<std::string, std::string>, eCAL::SServiceMethodInformation> service_info_map;

std::map<std::tuple<std::string, std::string>, eCAL::SServiceMethodInformation> service_info_map = 0;

github-actions · 2024-04-15T13:08:03Z

ecal/tests/cpp/util_test/src/util_getservices.cpp

+    EXPECT_EQ(service_info_map.size(), 1);
+
+    // check attributes
+    std::string req_type, resp_type;


warning: variable 'req_type' of type 'std::string' (aka 'basic_string') can be declared 'const' [misc-const-correctness]

std::string req_type, resp_type; ^

github-actions · 2024-04-15T13:08:03Z

ecal/tests/cpp/util_test/src/util_getservices.cpp

+    EXPECT_EQ(service_info_map.size(), 1);
+
+    // check attributes
+    std::string req_type, resp_type;


warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration]

Suggested change

std::string req_type, resp_type;

std::string req_type;

std::string resp_type;

github-actions · 2024-04-15T13:08:03Z

ecal/tests/cpp/util_test/src/util_getservices.cpp

+
+    // check attributes
+    std::string req_type, resp_type;
+    std::string req_desc, resp_desc;


warning: variable 'req_desc' of type 'std::string' (aka 'basic_string') can be declared 'const' [misc-const-correctness]

std::string req_desc, resp_desc; ^

github-actions · 2024-04-15T13:08:03Z

ecal/tests/cpp/util_test/src/util_getservices.cpp

+
+    // check attributes
+    std::string req_type, resp_type;
+    std::string req_desc, resp_desc;


warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration]

Suggested change

std::string req_desc, resp_desc;

std::string req_desc;

std::string resp_desc;

…tion provider (to make it testable)

github-actions

clang-tidy made some suggestions

github-actions · 2024-04-15T15:11:04Z

ecal/core/src/ecal_descgate.cpp

  }

-  void CDescGate::GetServices(std::map<std::tuple<std::string, std::string>, SServiceMethodInformation>& service_info_map_)
+  QualityTopicIdMap CDescGate::GetTopics(const SQualityTopicIdMap& topic_map_)


warning: method 'GetTopics' can be made static [readability-convert-member-functions-to-static]

ecal/core/src/ecal_descgate.h:123:

- QualityTopicIdMap GetTopics(const SQualityTopicIdMap& topic_map_); + static QualityTopicIdMap GetTopics(const SQualityTopicIdMap& topic_map_);

github-actions · 2024-04-15T15:11:04Z

ecal/core/src/ecal_descgate.cpp

  }

-  void CDescGate::GetServiceNames(std::vector<std::tuple<std::string, std::string>>& service_method_names_)
+  QualityServiceIdMap CDescGate::GetServices(const SQualityServiceIdMap& service_method_info_map_)


warning: method 'GetServices' can be made static [readability-convert-member-functions-to-static]

ecal/core/src/ecal_descgate.h:124:

- QualityServiceIdMap GetServices(const SQualityServiceIdMap& service_method_info_map_); + static QualityServiceIdMap GetServices(const SQualityServiceIdMap& service_method_info_map_);

github-actions

clang-tidy made some suggestions

ecal/tests/cpp/descgate_test/src/getpublisher.cpp

github-actions · 2024-04-15T16:41:56Z

ecal/tests/cpp/descgate_test/src/getpublisher.cpp

+
+#include <gtest/gtest.h>
+
+TEST(core_cpp_descgate, GetPublisher)


warning: all parameters should be named in a function [readability-named-parameter]

Suggested change

TEST(core_cpp_descgate, GetPublisher)

TEST(core_cpp_descgate /*unused*/, GetPublisher /*unused*/)

github-actions · 2024-04-15T16:41:56Z

ecal/tests/cpp/descgate_test/src/getpublisher.cpp

+  auto pub_map = desc_gate->GetPublisher();
+  EXPECT_EQ(0, pub_map.size());
+
+  eCAL::Registration::Sample reg_sample;


warning: variable 'reg_sample' is not initialized [cppcoreguidelines-init-variables]

Suggested change

eCAL::Registration::Sample reg_sample;

eCAL::Registration::Sample reg_sample = 0;

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 20 out of 21. Check the log or trigger a new build to see more.

github-actions · 2024-04-16T15:50:51Z

ecal/tests/cpp/descgate_test/src/getpublisher.cpp

+#define DESCGATE_EXPIRATION_MS 500
+


warning: replace macro with enum [modernize-macro-to-enum]

Suggested change

#define DESCGATE_EXPIRATION_MS 500

enum {

DESCGATE_EXPIRATION_MS = 500};

github-actions · 2024-04-16T15:50:51Z

ecal/tests/cpp/descgate_test/src/getpublisher.cpp

+#include <chrono>
+#include <thread>
+
+#define DESCGATE_EXPIRATION_MS 500


warning: macro 'DESCGATE_EXPIRATION_MS' defines an integral constant; prefer an enum instead [modernize-macro-to-enum]

#define DESCGATE_EXPIRATION_MS 500 ^

github-actions · 2024-04-16T15:50:51Z

ecal/tests/cpp/descgate_test/src/getpublisher.cpp

+{
+  eCAL::Registration::Sample CreatePublisher(const std::string& topic_name_)
+  {
+    eCAL::Registration::Sample reg_sample;


warning: variable 'reg_sample' is not initialized [cppcoreguidelines-init-variables]

Suggested change

eCAL::Registration::Sample reg_sample;

eCAL::Registration::Sample reg_sample = 0;

github-actions · 2024-04-16T15:50:51Z

ecal/tests/cpp/descgate_test/src/getpublisher.cpp

+
+  eCAL::Registration::Sample CreateSubscriber(const std::string& topic_name_)
+  {
+    eCAL::Registration::Sample reg_sample;


warning: variable 'reg_sample' is not initialized [cppcoreguidelines-init-variables]

Suggested change

eCAL::Registration::Sample reg_sample;

eCAL::Registration::Sample reg_sample = 0;

github-actions · 2024-04-16T15:50:51Z

ecal/tests/cpp/descgate_test/src/getpublisher.cpp

+
+  eCAL::Registration::Sample CreateService(const std::string& service_name_)
+  {
+    eCAL::Registration::Sample reg_sample;


warning: variable 'reg_sample' is not initialized [cppcoreguidelines-init-variables]

Suggested change

eCAL::Registration::Sample reg_sample;

eCAL::Registration::Sample reg_sample = 0;

github-actions · 2024-04-16T15:50:52Z

ecal/tests/cpp/descgate_test/src/getpublisher.cpp

+  EXPECT_EQ(0, desc_gate.GetSubscriber().size());
+}
+
+TEST(core_cpp_descgate, ServiceExpiration)


warning: all parameters should be named in a function [readability-named-parameter]

Suggested change

TEST(core_cpp_descgate, ServiceExpiration)

TEST(core_cpp_descgate /*unused*/, ServiceExpiration /*unused*/)

github-actions · 2024-04-16T15:50:52Z

ecal/tests/cpp/descgate_test/src/getpublisher.cpp

+
+  // apply sample 5 times, sample should not expire
+  auto runs(5);
+  while (runs--)


warning: implicit conversion 'int' -> bool [readability-implicit-bool-conversion]

Suggested change

while (runs--)

while ((runs--) != 0)

github-actions · 2024-04-16T15:50:52Z

ecal/tests/cpp/descgate_test/src/getpublisher.cpp

+  EXPECT_EQ(0, desc_gate.GetServices().size());
+}
+
+TEST(core_cpp_descgate, ManyService)


warning: all parameters should be named in a function [readability-named-parameter]

Suggested change

TEST(core_cpp_descgate, ManyService)

TEST(core_cpp_descgate /*unused*/, ManyService /*unused*/)

github-actions · 2024-04-16T15:50:52Z

ecal/tests/cpp/descgate_test/src/getpublisher.cpp

+  EXPECT_EQ(0, desc_gate.GetServices().size());
+}
+
+TEST(core_cpp_descgate, ClientExpiration)


warning: all parameters should be named in a function [readability-named-parameter]

Suggested change

TEST(core_cpp_descgate, ClientExpiration)

TEST(core_cpp_descgate /*unused*/, ClientExpiration /*unused*/)

github-actions · 2024-04-16T15:50:52Z

ecal/tests/cpp/descgate_test/src/getpublisher.cpp

+
+  // apply sample 5 times, sample should not expire
+  auto runs(5);
+  while (runs--)


warning: implicit conversion 'int' -> bool [readability-implicit-bool-conversion]

Suggested change

while (runs--)

while ((runs--) != 0)

github-actions

clang-tidy made some suggestions

ecal/core/include/ecal/ecal_util.h

github-actions · 2024-04-16T19:35:36Z

ecal/core/src/ecal_descgate.cpp

-      std::string msg = "eCAL Pub/Sub description mismatch for topic ";
-      msg += topic_name_;
-      eCAL::Logging::Log(log_level_warning, msg);
+  void CDescGate::RemTopicDescription(SQualityTopicIdMap& topic_info_map_, const std::string& topic_name_, const std::uint64_t& topic_id_)


warning: method 'RemTopicDescription' can be made static [readability-convert-member-functions-to-static]

ecal/core/src/ecal_descgate.h:132:

- void RemTopicDescription(SQualityTopicIdMap& topic_info_map_, + static void RemTopicDescription(SQualityTopicIdMap& topic_info_map_,

github-actions · 2024-04-16T19:35:36Z

ecal/core/src/ecal_descgate.cpp

-    , const SDataTypeInformation& request_type_information_
-    , const SDataTypeInformation& response_type_information_
-    , const QualityFlags description_quality_)
+  void CDescGate::RemServiceDescription(SQualityServiceIdMap& service_method_info_map_, const std::string& service_name_, const std::uint64_t& service_id_)


warning: method 'RemServiceDescription' can be made static [readability-convert-member-functions-to-static]

ecal/core/src/ecal_descgate.h:145:

- void RemServiceDescription(SQualityServiceIdMap& service_method_info_map_, + static void RemServiceDescription(SQualityServiceIdMap& service_method_info_map_,

github-actions · 2024-04-16T19:35:36Z

ecal/tests/cpp/descgate_test/src/getpublisher.cpp

+  EXPECT_EQ(0, desc_gate.GetClients().size());
+}
+
+TEST(core_cpp_descgate, ManyClient)


warning: all parameters should be named in a function [readability-named-parameter]

Suggested change

TEST(core_cpp_descgate, ManyClient)

TEST(core_cpp_descgate /*unused*/, ManyClient /*unused*/)

github-actions

clang-tidy made some suggestions

github-actions · 2024-04-17T05:52:52Z

ecal/tests/cpp/descgate_test/src/getpublisher.cpp

+  EXPECT_EQ(0, desc_gate.GetSubscriber().size());
+}
+
+TEST(core_cpp_descgate, SubscriberQualities)


warning: all parameters should be named in a function [readability-named-parameter]

Suggested change

TEST(core_cpp_descgate, SubscriberQualities)

TEST(core_cpp_descgate /*unused*/, SubscriberQualities /*unused*/)

types introduced for TopicId and ServiceId

github-actions

clang-tidy made some suggestions

ecal/core/include/ecal/ecal_util.h

github-actions · 2024-04-17T08:52:47Z

ecal/core/src/ecal_descgate.cpp

-      std::string msg = "eCAL Pub/Sub description mismatch for topic ";
-      msg += topic_name_;
-      eCAL::Logging::Log(log_level_warning, msg);
+  void CDescGate::RemTopicDescription(SQualityTopicIdMap& topic_info_map_, const std::string& topic_name_, const Util::TopicId& topic_id_)


warning: method 'RemTopicDescription' can be made static [readability-convert-member-functions-to-static]

ecal/core/src/ecal_descgate.h:132:

- void RemTopicDescription(SQualityTopicIdMap& topic_info_map_, + static void RemTopicDescription(SQualityTopicIdMap& topic_info_map_,

github-actions · 2024-04-17T08:52:47Z

ecal/core/src/ecal_descgate.cpp

-    , const SDataTypeInformation& request_type_information_
-    , const SDataTypeInformation& response_type_information_
-    , const QualityFlags description_quality_)
+  void CDescGate::RemServiceDescription(SQualityServiceIdMap& service_method_info_map_, const std::string& service_name_, const Util::ServiceId& service_id_)


warning: method 'RemServiceDescription' can be made static [readability-convert-member-functions-to-static]

ecal/core/src/ecal_descgate.h:145:

- void RemServiceDescription(SQualityServiceIdMap& service_method_info_map_, + static void RemServiceDescription(SQualityServiceIdMap& service_method_info_map_,

jitter of 100 ms added to util test timeouts

…bscriber -> CDescGate::GetSubscribers static functions ApplyTopicDescription, RemTopicDescription, ApplyServiceDescription, RemServiceDescription unique_ptr<map) -> map

github-actions

clang-tidy made some suggestions

github-actions · 2024-04-22T13:40:21Z

ecal/core/src/ecal_descgate.cpp

  }

-  void CDescGate::GetServices(std::map<std::tuple<std::string, std::string>, SServiceMethodInformation>& service_info_map_)
+  QualityTopicIdMap CDescGate::GetTopics(SQualityTopicIdMap& topic_map_)


warning: method 'GetTopics' can be made static [readability-convert-member-functions-to-static]

ecal/core/src/ecal_descgate.h:117:

- QualityTopicIdMap GetTopics(SQualityTopicIdMap& topic_map_); + static QualityTopicIdMap GetTopics(SQualityTopicIdMap& topic_map_);

github-actions · 2024-04-22T13:40:22Z

ecal/core/src/ecal_descgate.cpp

  }

-  void CDescGate::GetServiceNames(std::vector<std::tuple<std::string, std::string>>& service_method_names_)
+  QualityServiceIdMap CDescGate::GetServices(SQualityServiceIdMap& service_method_info_map_)


warning: method 'GetServices' can be made static [readability-convert-member-functions-to-static]

ecal/core/src/ecal_descgate.h:118:

- QualityServiceIdMap GetServices(SQualityServiceIdMap& service_method_info_map_); + static QualityServiceIdMap GetServices(SQualityServiceIdMap& service_method_info_map_);

vector > set

github-actions

clang-tidy made some suggestions

github-actions · 2024-04-22T20:19:28Z

ecal/tests/cpp/util_test/src/util_getclients.cpp

+  // initialize eCAL API
+  eCAL::Initialize(0, nullptr, "core_cpp_util");
+
+  std::map<eCAL::Util::SServiceMethod, eCAL::SServiceMethodInformation> client_info_map;


warning: variable 'client_info_map' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::map<eCAL::Util::SServiceMethod, eCAL::SServiceMethodInformation> client_info_map;

std::map<eCAL::Util::SServiceMethod, eCAL::SServiceMethodInformation> client_info_map = 0;

github-actions · 2024-04-22T20:19:28Z

ecal/tests/cpp/util_test/src/util_getclients.cpp

+    EXPECT_EQ(client_info_map.size(), 1);
+
+    // check client/method names
+    std::set<eCAL::Util::SServiceMethod> client_method_names;


warning: variable 'client_method_names' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::set<eCAL::Util::SServiceMethod> client_method_names;

std::set<eCAL::Util::SServiceMethod> client_method_names = 0;

github-actions · 2024-04-22T20:19:28Z

ecal/tests/cpp/util_test/src/util_getclients.cpp

+  // initialize eCAL API
+  eCAL::Initialize(0, nullptr, "core_cpp_util");
+
+  std::map<eCAL::Util::SServiceMethod, eCAL::SServiceMethodInformation> client_info_map;


warning: variable 'client_info_map' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::map<eCAL::Util::SServiceMethod, eCAL::SServiceMethodInformation> client_info_map;

std::map<eCAL::Util::SServiceMethod, eCAL::SServiceMethodInformation> client_info_map = 0;

github-actions · 2024-04-22T20:19:28Z

ecal/tests/cpp/util_test/src/util_getclients.cpp

+  // initialize eCAL API
+  eCAL::Initialize(0, nullptr, "core_cpp_util");
+
+  std::map<eCAL::Util::SServiceMethod, eCAL::SServiceMethodInformation> client_info_map;


warning: variable 'client_info_map' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::map<eCAL::Util::SServiceMethod, eCAL::SServiceMethodInformation> client_info_map;

std::map<eCAL::Util::SServiceMethod, eCAL::SServiceMethodInformation> client_info_map = 0;

github-actions · 2024-04-22T20:19:29Z

ecal/tests/cpp/util_test/src/util_getservices.cpp

+  // initialize eCAL API
+  eCAL::Initialize(0, nullptr, "core_cpp_util");
+
+  std::map<eCAL::Util::SServiceMethod, eCAL::SServiceMethodInformation> service_info_map;


warning: variable 'service_info_map' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::map<eCAL::Util::SServiceMethod, eCAL::SServiceMethodInformation> service_info_map;

std::map<eCAL::Util::SServiceMethod, eCAL::SServiceMethodInformation> service_info_map = 0;

github-actions · 2024-04-22T20:19:29Z

ecal/tests/cpp/util_test/src/util_getservices.cpp

+    EXPECT_EQ(service_info_map.size(), 1);
+
+    // check service/method names
+    std::set<eCAL::Util::SServiceMethod> service_method_names;


warning: variable 'service_method_names' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::set<eCAL::Util::SServiceMethod> service_method_names;

std::set<eCAL::Util::SServiceMethod> service_method_names = 0;

github-actions · 2024-04-22T20:19:29Z

ecal/tests/cpp/util_test/src/util_getservices.cpp

+  // initialize eCAL API
+  eCAL::Initialize(0, nullptr, "core_cpp_util");
+
+  std::map<eCAL::Util::SServiceMethod, eCAL::SServiceMethodInformation> service_info_map;


warning: variable 'service_info_map' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::map<eCAL::Util::SServiceMethod, eCAL::SServiceMethodInformation> service_info_map;

std::map<eCAL::Util::SServiceMethod, eCAL::SServiceMethodInformation> service_info_map = 0;

github-actions · 2024-04-22T20:19:29Z

ecal/tests/cpp/util_test/src/util_getservices.cpp

+  // initialize eCAL API
+  eCAL::Initialize(0, nullptr, "core_cpp_util");
+
+  std::map<eCAL::Util::SServiceMethod, eCAL::SServiceMethodInformation> service_info_map;


warning: variable 'service_info_map' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::map<eCAL::Util::SServiceMethod, eCAL::SServiceMethodInformation> service_info_map;

std::map<eCAL::Util::SServiceMethod, eCAL::SServiceMethodInformation> service_info_map = 0;

KerstinKeller

Sorry I have some more remarks. some might be from yesterday, and outdated, but others are from today.

ecal/core/include/ecal/ecal_util.h

ecal/core/src/cimpl/ecal_util_cimpl.cpp

ecal/core/src/ecal_descgate.h

ecal/core/src/ecal_util.cpp

ecal/core/include/ecal/ecal_util.h

ecal/core/src/ecal_util.cpp

KerstinKeller · 2024-04-24T11:37:01Z

ecal/core/src/ecal_descgate.h

+
+    bool operator<(const SServiceIdKey& other) const
+    {
+      return std::tie(service_name, service_id) < std::tie(other.service_name, other.service_id);


Did you "forget" the method_name in the comparison, or is this by intent?

KerstinKeller

Looks good, now.

rex-schilasky added 3 commits April 10, 2024 11:09

topic, clients, services get unregistered actively from DescGate

6b6cf04

minor logic bug

5b8c21b

expmap test moved to core (solution folder)

a68af97

rex-schilasky added the cherry-pick-to-NONE Don't cherry-pick these changes label Apr 10, 2024

github-actions bot reviewed Apr 10, 2024

View reviewed changes

rex-schilasky marked this pull request as draft April 11, 2024 15:11

rex-schilasky added 2 commits April 12, 2024 15:52

descgate first draft finished

e3f0afd

ecal_util started to adapt

minor fixes

62a2d24

github-actions bot reviewed Apr 12, 2024

View reviewed changes

Merge branch 'master' into feature/active-descgate-unregistration

2f93bfc

github-actions bot reviewed Apr 12, 2024

View reviewed changes

legacy gettopics_xy API reimplemented

3e67a72

github-actions bot reviewed Apr 12, 2024

View reviewed changes

rex-schilasky added 2 commits April 14, 2024 20:51

next refactoring

12351f8

clang-tidy and minor type fix

f4b789c

github-actions bot reviewed Apr 14, 2024

View reviewed changes

argument name fixes

45a7c07

github-actions bot reviewed Apr 14, 2024

View reviewed changes

service data type info quality split for request and response

a46fc88

util test, getservices, getclients started to refactor

github-actions bot reviewed Apr 15, 2024

View reviewed changes

clang-tidy

96d7fa8

github-actions bot reviewed Apr 15, 2024

View reviewed changes

cut descgate interfaces to config, registration receiver and registra…

46d630a

…tion provider (to make it testable)

github-actions bot reviewed Apr 15, 2024

View reviewed changes

simple descgate test added

7c62264

github-actions bot reviewed Apr 15, 2024

View reviewed changes

desc_gate added

79cc993

github-actions bot reviewed Apr 16, 2024

View reviewed changes

rex-schilasky added 2 commits April 16, 2024 21:04

topic_id, service_id now uint64_t

f4b7753

minimal send sample reverted

ef29175

github-actions bot reviewed Apr 16, 2024

View reviewed changes

desc_gate test fixed

d232e13

github-actions bot reviewed Apr 17, 2024

View reviewed changes

rex-schilasky marked this pull request as ready for review April 17, 2024 06:05

DescQualityFlags operators added again

e819830

types introduced for TopicId and ServiceId

github-actions bot reviewed Apr 17, 2024

View reviewed changes

rex-schilasky added 5 commits April 17, 2024 16:52

Merge branch 'master' into feature/active-descgate-unregistration

6bd7b83

descgate getpublisher test corrected

1897fe6

Merge branch 'master' into feature/active-descgate-unregistration

1223e1e

clang-tidy

1df54d1

jitter of 100 ms added to util test timeouts

CDescGate::GetPublisher -> CDescGate::GetPublishers, CDescGate::GetSu…

9749d72

…bscriber -> CDescGate::GetSubscribers static functions ApplyTopicDescription, RemTopicDescription, ApplyServiceDescription, RemServiceDescription unique_ptr<map) -> map

github-actions bot reviewed Apr 22, 2024

View reviewed changes

GetPublisher > GetPublishers ..

5fcdbe7

vector > set

github-actions bot reviewed Apr 22, 2024

View reviewed changes

includes added

d6b0709

KerstinKeller reviewed Apr 23, 2024

View reviewed changes

rex-schilasky added 4 commits April 23, 2024 20:54

a few keller-tidy

f82d20d

a few more keller-tidy

afa72a2

some additional usings added

3c8dd97

Merge branch 'master' into feature/active-descgate-unregistration

1339572

KerstinKeller reviewed Apr 24, 2024

View reviewed changes

SServiceIdKey compare operator improved

d4769e5

KerstinKeller approved these changes Apr 24, 2024

View reviewed changes

rex-schilasky merged commit 1acd2ee into master Apr 24, 2024
15 checks passed

rex-schilasky deleted the feature/active-descgate-unregistration branch April 24, 2024 16:19

	STopicInfoQuality& topic_info = (*m_topic_info_map.map)[topic_name_];
	STopicInfoQuality const& topic_info = (*m_topic_info_map.map)[topic_name_];

	TEST(core_cpp_core, ExpMap_FindConst)
	TEST(core_cpp_core /unused/, ExpMap_FindConst /unused/)

	TEST(core_cpp_core, ExpMap_Iterate)
	TEST(core_cpp_core /unused/, ExpMap_Iterate /unused/)

	TEST(core_cpp_core, ExpMap_ConstExpMapIterate)
	TEST(core_cpp_core /unused/, ExpMap_ConstExpMapIterate /unused/)

	TEST(core_cpp_core, ExpMap_Empty)
	TEST(core_cpp_core /unused/, ExpMap_Empty /unused/)

	TEST(core_cpp_core, ExpMap_Size)
	TEST(core_cpp_core /unused/, ExpMap_Size /unused/)

	SServiceMethodInformation service_method_info = GetHighestQualifiedServiceMethodInformation(service_method_info_vec);
	SServiceMethodInformation const service_method_info = GetHighestQualifiedServiceMethodInformation(service_method_info_vec);

	TEST(core_cpp_core, ExpMap_Remove)
	TEST(core_cpp_core /unused/, ExpMap_Remove /unused/)

		#define CMN_REGISTRATION_REFRESH 1000
		#define CMN_MONITORING_TIMEOUT 5000


		#include <gtest/gtest.h>

		#define CMN_REGISTRATION_REFRESH 1000

		@@ -149,19 +245,27 @@
		ECAL_API bool GetTopicDataTypeInformation(const std::string& topic_name_, SDataTypeInformation& topic_info_);

	std::vector<SQualityServiceInfo> service_method_info_vec = GetQualityServiceInfoVec(service_name_, method_name_, GetServices());
	std::vector<SQualityServiceInfo> const service_method_info_vec = GetQualityServiceInfoVec(service_name_, method_name_, GetServices());

	const Util::DescQualityFlags topic_quality_);
	Util::DescQualityFlags topic_quality_);

	const Util::DescQualityFlags request_type_quality_,
	Util::DescQualityFlags request_type_quality_,

	const Util::DescQualityFlags response_type_quality_);
	Util::DescQualityFlags response_type_quality_);

	TEST(core_cpp_util, ClientDifferentQualities)
	TEST(core_cpp_util /unused/, ClientDifferentQualities /unused/)

	std::map<std::tuple<std::string, std::string>, eCAL::SServiceMethodInformation> client_info_map;
	std::map<std::tuple<std::string, std::string>, eCAL::SServiceMethodInformation> client_info_map = 0;

	std::string req_type, resp_type;
	std::string req_type;
	std::string resp_type;

	std::string req_desc, resp_desc;
	std::string req_desc;
	std::string resp_desc;


		enum { CMN_MONITORING_TIMEOUT = 5000 };

		TEST(core_cpp_util, ServiceExpiration)

[core] active entity unregistration in descgate #1520

[core] active entity unregistration in descgate #1520

Conversation

rex-schilasky commented Apr 10, 2024 • edited Loading

Description

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Apr 10, 2024

Choose a reason for hiding this comment

github-actions bot Apr 10, 2024

Choose a reason for hiding this comment

github-actions bot Apr 10, 2024

Choose a reason for hiding this comment

github-actions bot Apr 10, 2024

Choose a reason for hiding this comment

github-actions bot Apr 10, 2024

Choose a reason for hiding this comment

github-actions bot Apr 10, 2024

Choose a reason for hiding this comment

github-actions bot Apr 10, 2024

Choose a reason for hiding this comment

github-actions bot Apr 10, 2024

Choose a reason for hiding this comment

github-actions bot Apr 10, 2024

Choose a reason for hiding this comment

github-actions bot Apr 10, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Apr 12, 2024

Choose a reason for hiding this comment

github-actions bot Apr 12, 2024

Choose a reason for hiding this comment

github-actions bot Apr 12, 2024

Choose a reason for hiding this comment

github-actions bot Apr 12, 2024

Choose a reason for hiding this comment

github-actions bot Apr 12, 2024

Choose a reason for hiding this comment

github-actions bot Apr 12, 2024

Choose a reason for hiding this comment

github-actions bot Apr 12, 2024

Choose a reason for hiding this comment

github-actions bot Apr 12, 2024

Choose a reason for hiding this comment

github-actions bot Apr 12, 2024

Choose a reason for hiding this comment

github-actions bot Apr 12, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Apr 12, 2024

Choose a reason for hiding this comment

github-actions bot Apr 12, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Apr 12, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Apr 14, 2024

Choose a reason for hiding this comment

github-actions bot Apr 14, 2024

Choose a reason for hiding this comment

github-actions bot Apr 14, 2024

Choose a reason for hiding this comment

github-actions bot Apr 14, 2024

Choose a reason for hiding this comment

github-actions bot Apr 14, 2024

Choose a reason for hiding this comment

github-actions bot Apr 14, 2024

Choose a reason for hiding this comment

github-actions bot Apr 14, 2024

Choose a reason for hiding this comment

github-actions bot Apr 14, 2024

Choose a reason for hiding this comment

github-actions bot Apr 14, 2024

Choose a reason for hiding this comment

github-actions bot Apr 14, 2024

rex-schilasky commented Apr 10, 2024 •

edited

Loading

	TEST(core_cpp_util, ServiceExpiration)
	TEST(core_cpp_util /unused/, ServiceExpiration /unused/)

	std::vector<std::tuple<std::string, std::string>> service_method_names;
	std::vector<std::tuple<std::string, std::string>> service_method_names = 0;


		#include <gtest/gtest.h>

		TEST(core_cpp_descgate, GetPublisher)

	TEST(core_cpp_descgate, GetPublisher)
	TEST(core_cpp_descgate /unused/, GetPublisher /unused/)

	eCAL::Registration::Sample reg_sample;
	eCAL::Registration::Sample reg_sample = 0;

	TEST(core_cpp_descgate, ServiceExpiration)
	TEST(core_cpp_descgate /unused/, ServiceExpiration /unused/)

	TEST(core_cpp_descgate, ManyService)
	TEST(core_cpp_descgate /unused/, ManyService /unused/)

	TEST(core_cpp_descgate, ClientExpiration)
	TEST(core_cpp_descgate /unused/, ClientExpiration /unused/)

	TEST(core_cpp_descgate, ManyClient)
	TEST(core_cpp_descgate /unused/, ManyClient /unused/)

	TEST(core_cpp_descgate, SubscriberQualities)
	TEST(core_cpp_descgate /unused/, SubscriberQualities /unused/)