Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] active entity unregistration in descgate #1520
[core] active entity unregistration in descgate #1520
Changes from 12 commits
6b6cf04
5b8c21b
a68af97
e3f0afd
62a2d24
2f93bfc
3e67a72
12351f8
f4b789c
45a7c07
a46fc88
96d7fa8
46d630a
7c62264
79cc993
f4b7753
ef29175
d232e13
e819830
6bd7b83
1897fe6
1223e1e
1df54d1
9749d72
5fcdbe7
d6b0709
f82d20d
afa72a2
3c8dd97
1339572
d4769e5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function 'eCAL::Util::GetClients' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
Additional context
ecal/core/src/ecal_util.cpp:518: the definition seen here
ecal/core/include/ecal/ecal_util.h:307: differing parameters are named here: ('quality_client_info_map_'), in definition: ('quality_client_method_info_map_')