-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#1755 Distinct overloads for arithmetic types for logstream #2022
iox-#1755 Distinct overloads for arithmetic types for logstream #2022
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2022 +/- ##
==========================================
+ Coverage 74.27% 74.32% +0.04%
==========================================
Files 413 413
Lines 16055 16103 +48
Branches 2246 2246
==========================================
+ Hits 11925 11968 +43
- Misses 3411 3415 +4
- Partials 719 720 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some typos, but you can ignore my comment and merge if there's nothing else to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only minor nitpicks. From my side we can merge this.
6062429
to
95e4a7c
Compare
Pre-Review Checklist for the PR Author
Changelog updated in the unreleased section including API breaking changesiox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
This PR adds distinct overloads for
LogStream& operator <<
. This enabled implicit type conversion to the underlying type of e.g.Wrapper<T>
if the implicitoperator T()
is implemented.Additionally, it is finally possible to log
char
instead of onlysigned char
andunsigned char
.Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References