Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Logger #1755

Open
5 of 8 tasks
elBoberido opened this issue Oct 20, 2022 · 4 comments · Fixed by #2022, #2037, #2038, #2043 or #2222
Open
5 of 8 tasks

Enhance Logger #1755

elBoberido opened this issue Oct 20, 2022 · 4 comments · Fixed by #2022, #2037, #2038, #2043 or #2222
Assignees
Labels
Milestone

Comments

@elBoberido
Copy link
Member

elBoberido commented Oct 20, 2022

Brief feature description

Enhance the basic logger implementation from #1345

Detailed information

  • use distinct methods in LogStream& operator<< instead of the templated method with SFINEA for arithmetic types
    • the template method prevents the implicit conversion of types to an arithmetic type and the function overloading selects LogStream& operator(const bool value) for e.g. IOX_LOG(INFO) << greater_or_equal<uint32_t, 42>(13)
  • find a good way for lazy evaluation
    • if statement without braces causes warnings in the static code analyzer
    • variadic macros/templates with some lambda magic might work
  • C-Binding?
  • extend LogStream/ConsoleLogger for LogBin and LogRaw
  • extend LogStream/ConsoleLogger for char
    • currently int8_t and uint8_t are supported which desugar to signed char and unsigned char
    • instead of 'a' only "a" works
  • add customization options like
    • switch between system clock, steady clock or just a counter
    • add thread ID from where the logger was called
    • optionally print file, line and function in ConsoleLogger
  • use the iox platform for all POSIX calls
    • the initial idea was to place the logger one layer below the platform in order to be able to change the logger via the platform files but this should be done in a different way, e.g. by a -DIOX_LOGGER_PATH cmake argument
  • redirect the printing in the platform layer to the logger
@elBoberido elBoberido added the enhancement New feature label Oct 20, 2022
@elBoberido elBoberido added this to the Medium prio milestone Oct 20, 2022
@elBoberido elBoberido self-assigned this Oct 20, 2022
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Nov 14, 2022
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Dec 19, 2022
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Dec 20, 2022
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 6, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 6, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 6, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Feb 6, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Apr 3, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Apr 3, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Apr 3, 2023
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Apr 3, 2023
elBoberido added a commit that referenced this issue Apr 4, 2023
…ll-places

iox-#1755 Use new log macros in all places
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Apr 13, 2023
elBoberido added a commit that referenced this issue Apr 18, 2023
…-terminate

iox-#1755 flush testing logger on terminate
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Sep 6, 2023
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Sep 6, 2023
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Sep 6, 2023
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Sep 8, 2023
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Sep 16, 2023
elBoberido added a commit that referenced this issue Sep 18, 2023
…for-arithmetic-types-for-logstream

iox-#1755 Distinct overloads for arithmetic types for logstream
@elBoberido elBoberido linked a pull request Sep 18, 2023 that will close this issue
21 tasks
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Oct 24, 2023
elBoberido added a commit that referenced this issue Oct 25, 2023
@elBoberido elBoberido linked a pull request Oct 25, 2023 that will close this issue
21 tasks
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Mar 11, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Mar 11, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Mar 11, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Mar 11, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Mar 11, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Mar 11, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Mar 11, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Mar 11, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Mar 11, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Mar 11, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Mar 11, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Mar 11, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Mar 11, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Mar 11, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Mar 11, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Mar 11, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Mar 11, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Mar 12, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Mar 12, 2024
elBoberido added a commit that referenced this issue Mar 12, 2024
…n-the-platform-layer-to-the-logger

iox-#1755 Redirect printing in the platform layer to the logger
@elBoberido elBoberido linked a pull request Mar 12, 2024 that will close this issue
22 tasks
@github-project-automation github-project-automation bot moved this to To do in v4.0 Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment