Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1755 Reintroduce lazy evaluation for the logging #2037

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Sep 28, 2023

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

This PR introduces a new macro for logging which utilizes lazy evaluation. The port to the new macro will happen in a follow up PR.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added the enhancement New feature label Sep 28, 2023
@elBoberido elBoberido self-assigned this Sep 28, 2023
@elBoberido
Copy link
Member Author

@FerdinandSpitzschnueffler @mossmaurice @dkroenke @MatthiasKillat @elfenpiff feel free to add yourself as reviewer

@elBoberido elBoberido force-pushed the iox-1755-reintroduce-lazy-evaluation-for-the-logging branch from b4c36e1 to f9b3409 Compare September 28, 2023 19:49
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #2037 (2a5da9a) into master (4fb0b5f) will decrease coverage by 1.52%.
Report is 9 commits behind head on master.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2037      +/-   ##
==========================================
- Coverage   74.23%   72.71%   -1.52%     
==========================================
  Files         417      417              
  Lines       16290    16285       -5     
  Branches     2277     2887     +610     
==========================================
- Hits        12093    11842     -251     
- Misses       3458     3469      +11     
- Partials      739      974     +235     
Flag Coverage Δ
unittests 72.50% <0.00%> (-1.52%) ⬇️
unittests_timing 15.03% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ofs/reporting/include/iox/detail/log/logstream.inl 95.68% <ø> (-0.11%) ⬇️
iceoryx_hoofs/reporting/include/iox/logging.hpp 50.00% <ø> (ø)
...error_reporting/custom/default/error_reporting.inl 73.21% <0.00%> (-14.72%) ⬇️

... and 69 files with indirect coverage changes

@elBoberido elBoberido force-pushed the iox-1755-reintroduce-lazy-evaluation-for-the-logging branch from 62bb5c1 to 8deab7e Compare September 28, 2023 22:21
@elBoberido elBoberido force-pushed the iox-1755-reintroduce-lazy-evaluation-for-the-logging branch 6 times, most recently from f42bd94 to a358a0f Compare September 29, 2023 17:56
@elBoberido elBoberido force-pushed the iox-1755-reintroduce-lazy-evaluation-for-the-logging branch from a358a0f to 545cacc Compare September 30, 2023 12:24
Copy link
Contributor

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only nitpicks.

doc/design/logging.md Outdated Show resolved Hide resolved
doc/design/logging.md Outdated Show resolved Hide resolved
@elBoberido
Copy link
Member Author

@mossmaurice @dkroenke @MatthiasKillat @elfenpiff anyone who would like to do the second review?

We desperately need to change the number of reviewers. There is another open PR which is based on this one and I have a further branch which is ready to review. With this speed I won't be able to get this in this year and I'm currently blocked by the slow review process.

@elBoberido
Copy link
Member Author

@mossmaurice mossmaurice self-requested a review October 24, 2023 12:42
Copy link
Contributor

@mossmaurice mossmaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

tools/scripts/clang_tidy_check.sh Show resolved Hide resolved
@elBoberido elBoberido merged commit 36f0c44 into eclipse-iceoryx:master Oct 24, 2023
16 of 17 checks passed
@elBoberido elBoberido deleted the iox-1755-reintroduce-lazy-evaluation-for-the-logging branch October 24, 2023 12:55
@elBoberido elBoberido linked an issue Oct 24, 2023 that may be closed by this pull request
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Logger
3 participants