-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#1755 Reintroduce lazy evaluation for the logging #2037
iox-#1755 Reintroduce lazy evaluation for the logging #2037
Conversation
@FerdinandSpitzschnueffler @mossmaurice @dkroenke @MatthiasKillat @elfenpiff feel free to add yourself as reviewer |
b4c36e1
to
f9b3409
Compare
Codecov Report
@@ Coverage Diff @@
## master #2037 +/- ##
==========================================
- Coverage 74.23% 72.71% -1.52%
==========================================
Files 417 417
Lines 16290 16285 -5
Branches 2277 2887 +610
==========================================
- Hits 12093 11842 -251
- Misses 3458 3469 +11
- Partials 739 974 +235
Flags with carried forward coverage won't be shown. Click here to find out more.
|
62bb5c1
to
8deab7e
Compare
f42bd94
to
a358a0f
Compare
a358a0f
to
545cacc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only nitpicks.
@mossmaurice @dkroenke @MatthiasKillat @elfenpiff anyone who would like to do the second review? We desperately need to change the number of reviewers. There is another open PR which is based on this one and I have a further branch which is ready to review. With this speed I won't be able to get this in this year and I'm currently blocked by the slow review process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
This PR introduces a new macro for logging which utilizes lazy evaluation. The port to the new macro will happen in a follow up PR.
Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References