-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#1755 Port to new macro #2038
Merged
elBoberido
merged 2 commits into
eclipse-iceoryx:master
from
elBoberido:iox-1755-port-to-new-macro
Oct 24, 2023
Merged
iox-#1755 Port to new macro #2038
elBoberido
merged 2 commits into
eclipse-iceoryx:master
from
elBoberido:iox-1755-port-to-new-macro
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elBoberido
changed the title
iox-#1755 Port to new macro
[Based on #2037] iox-#1755 Port to new macro
Sep 28, 2023
Codecov Report
@@ Coverage Diff @@
## master #2038 +/- ##
==========================================
+ Coverage 74.23% 74.43% +0.19%
==========================================
Files 417 417
Lines 16290 15986 -304
Branches 2277 2272 -5
==========================================
- Hits 12093 11899 -194
+ Misses 3458 3304 -154
- Partials 739 783 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
|
elBoberido
force-pushed
the
iox-1755-port-to-new-macro
branch
9 times, most recently
from
September 30, 2023 13:24
fa5f5db
to
130d0a6
Compare
elBoberido
force-pushed
the
iox-1755-port-to-new-macro
branch
from
October 14, 2023 15:28
130d0a6
to
f213cb9
Compare
elBoberido
changed the title
[Based on #2037] iox-#1755 Port to new macro
iox-#1755 Port to new macro
Oct 24, 2023
elBoberido
force-pushed
the
iox-1755-port-to-new-macro
branch
from
October 24, 2023 12:58
0234a89
to
f5c4ae5
Compare
@FerdinandSpitzschnueffler @mossmaurice @dkroenke @MatthiasKillat @elfenpiff @budrus feel free to add yourself as reviewer |
elfenpiff
approved these changes
Oct 24, 2023
FerdinandSpitzschnueffler
approved these changes
Oct 24, 2023
Open
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
This PR ports the code to the new log macro with lazy evaluation and removes the old macro.
Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References