-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#1755 Add log bin and log raw #2043
iox-#1755 Add log bin and log raw #2043
Conversation
5d9bf74
to
63bd1d0
Compare
Codecov Report
@@ Coverage Diff @@
## master #2043 +/- ##
==========================================
+ Coverage 72.71% 74.49% +1.78%
==========================================
Files 417 417
Lines 16285 16046 -239
Branches 2887 2279 -608
==========================================
+ Hits 11842 11954 +112
+ Misses 3469 3308 -161
+ Partials 974 784 -190
Flags with carried forward coverage won't be shown. Click here to find out more.
|
63bd1d0
to
be9ccb2
Compare
be9ccb2
to
83201e1
Compare
@FerdinandSpitzschnueffler @mossmaurice @dkroenke @MatthiasKillat @elfenpiff @budrus feel free to add yourself as reviewer |
iceoryx_hoofs/reporting/include/iox/detail/log/building_blocks/console_logger.inl
Outdated
Show resolved
Hide resolved
iceoryx_hoofs/reporting/include/iox/detail/log/building_blocks/console_logger.inl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
This PR adds logging supports for binary format and raw format. These features were not implemented when the logger was refactored.
Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References