Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1755 Add log bin and log raw #2043

Merged

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Oct 15, 2023

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

This PR adds logging supports for binary format and raw format. These features were not implemented when the logger was refactored.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added the enhancement New feature label Oct 15, 2023
@elBoberido elBoberido self-assigned this Oct 15, 2023
@elBoberido elBoberido force-pushed the iox-1755-add-log-bin-and-log-raw branch 2 times, most recently from 5d9bf74 to 63bd1d0 Compare October 15, 2023 23:51
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #2043 (9cc8c20) into master (36f0c44) will increase coverage by 1.78%.
Report is 18 commits behind head on master.
The diff coverage is 38.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2043      +/-   ##
==========================================
+ Coverage   72.71%   74.49%   +1.78%     
==========================================
  Files         417      417              
  Lines       16285    16046     -239     
  Branches     2887     2279     -608     
==========================================
+ Hits        11842    11954     +112     
+ Misses       3469     3308     -161     
+ Partials      974      784     -190     
Flag Coverage Δ
unittests 74.28% <38.11%> (+1.77%) ⬆️
unittests_timing 15.26% <0.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ceoryx_binding_c/source/c2cpp_enum_translation.cpp 100.00% <100.00%> (+10.81%) ⬆️
iceoryx_binding_c/source/c_publisher.cpp 92.50% <100.00%> (+3.75%) ⬆️
iceoryx_binding_c/source/c_subscriber.cpp 91.56% <100.00%> (+3.61%) ⬆️
iceoryx_binding_c/source/c_user_trigger.cpp 94.44% <100.00%> (+5.55%) ⬆️
...eoryx_hoofs/design/source/functional_interface.cpp 100.00% <100.00%> (+33.33%) ⬆️
...include/iceoryx_hoofs/posix_wrapper/posix_call.hpp 100.00% <ø> (ø)
iceoryx_hoofs/memory/source/bump_allocator.cpp 100.00% <100.00%> (+8.33%) ⬆️
iceoryx_hoofs/primitives/include/iox/size.hpp 50.00% <ø> (ø)
...ofs/reporting/include/iox/detail/log/logstream.inl 96.37% <100.00%> (+0.68%) ⬆️
...include/iox/log/building_blocks/console_logger.hpp 100.00% <ø> (ø)
... and 84 more

... and 1 file with indirect coverage changes

@elBoberido elBoberido force-pushed the iox-1755-add-log-bin-and-log-raw branch from 63bd1d0 to be9ccb2 Compare October 24, 2023 13:08
@elBoberido elBoberido force-pushed the iox-1755-add-log-bin-and-log-raw branch from be9ccb2 to 83201e1 Compare October 24, 2023 14:24
@elBoberido elBoberido changed the title [Based on #2038] iox-#1755 Add log bin and log raw iox-#1755 Add log bin and log raw Oct 24, 2023
@elBoberido
Copy link
Member Author

@FerdinandSpitzschnueffler @mossmaurice @dkroenke @MatthiasKillat @elfenpiff @budrus feel free to add yourself as reviewer

@mossmaurice mossmaurice self-requested a review October 24, 2023 17:29
Copy link
Contributor

@mossmaurice mossmaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@elBoberido elBoberido merged commit 89ea8f7 into eclipse-iceoryx:master Oct 25, 2023
@elBoberido elBoberido deleted the iox-1755-add-log-bin-and-log-raw branch October 25, 2023 11:38
@elBoberido elBoberido linked an issue Oct 25, 2023 that may be closed by this pull request
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Logger
3 participants