Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#392] noisy logger #393

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Sep 25, 2024

Notes for Reviewer

Sets default log level to LogLevel:Warn.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Closes #392

@elfenpiff elfenpiff force-pushed the iox2-392-noisy-logger branch from afe3303 to 27ba793 Compare September 25, 2024 07:42
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.00%. Comparing base (25dd2a6) to head (5070b05).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
- Coverage   79.44%   79.00%   -0.44%     
==========================================
  Files         193      193              
  Lines       22702    22702              
==========================================
- Hits        18035    17936      -99     
- Misses       4667     4766      +99     
Files with missing lines Coverage Δ
iceoryx2-bb/log/src/lib.rs 64.00% <ø> (ø)

... and 19 files with indirect coverage changes

orecham
orecham previously approved these changes Sep 25, 2024
@orecham orecham mentioned this pull request Sep 25, 2024
17 tasks
@elBoberido
Copy link
Member

@elfenpiff do you think you could sneak in the new benchmark images for the main README in this PR?

@elfenpiff
Copy link
Contributor Author

@elBoberido the benchmark images are already the newest ones. Take a look at the first image where iceoryx2 is close to zero and 10 times faster than iceoryx

@elBoberido
Copy link
Member

Oh, I thought the one which compares the latency to the last release would be the default 😅

@elfenpiff elfenpiff merged commit cb72d02 into eclipse-iceoryx:main Sep 25, 2024
53 of 56 checks passed
@elfenpiff elfenpiff deleted the iox2-392-noisy-logger branch September 25, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Noisy logger
3 participants