-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#394] sample mut uninit #395
[#394] sample mut uninit #395
Conversation
iceoryx2-bb/log/src/lib.rs
Outdated
@@ -161,7 +161,7 @@ static DEFAULT_LOGGER: logger::log::Logger = logger::log::Logger::new(); | |||
#[cfg(not(any(feature = "logger_log", feature = "logger_tracing")))] | |||
static DEFAULT_LOGGER: logger::console::Logger = logger::console::Logger::new(); | |||
|
|||
const DEFAULT_LOG_LEVEL: u8 = LogLevel::Trace as u8; | |||
const DEFAULT_LOG_LEVEL: u8 = LogLevel::Warn as u8; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is based on #393
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is ... I forget to mention this.
But it was an accident
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elfenpiff Looks good. Ping me for approval after rebasing on main
or merging #393.
53f2c3c
to
9c4c1d7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #395 +/- ##
==========================================
- Coverage 79.01% 79.00% -0.02%
==========================================
Files 194 194
Lines 22730 22730
==========================================
- Hits 17961 17958 -3
- Misses 4769 4772 +3
|
…_init_sample() into assume_init()
9c4c1d7
to
88d7507
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The request changes is just to make you aware of my comments. If you dismiss them, I'm fine with merging.
852f747
to
dbff454
Compare
Well, obviously I did not find time to look at it, so no reason to block the PR.
Notes for Reviewer
SampleMutUninit
struct that does not offer asend
methodsend_sample
intosend
since it was weird to readsend_sample(std::move(sample))
, this is much cleanersend(std::move(sample))
.SampleMut
has no C binding, the C++ implementation is done directly via the C API, otherwise it would be much more code on the FFI layerPre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #394