[#394] sample mut uninit #395
+741
−279
Merged
Task list completed / task-list-completed
Started
2024-09-27 13:01:32
ago
15 / 16 tasks completed
1 task still to be completed
Details
Required Tasks
| Task | Status |
|---|---|
Fixes the problem that uninitialized samples can be sent by introducing a SampleMutUninit struct that does not offer a send method |
Incomplete |
Renames the method send_sample into send since it was weird to read send_sample(std::move(sample)), this is much cleaner send(std::move(sample)). |
Incomplete |
SampleMut has no C binding, the C++ implementation is done directly via the C API, otherwise it would be much more code on the FFI layer |
Incomplete |
| Add sensible notes for the reviewer | Completed |
| PR title is short, expressive and meaningful | Completed |
| Relevant issues are linked in the References section | Completed |
Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT |
Completed |
Branch follows the naming format (iox2-123-introduce-posix-ipc-example) |
Completed |
Commit messages have the issue ID ([#123] Add posix ipc example) |
Completed |
| Commit author matches [Eclipse Contributor Agreement][eca] (and ECA is signed) | Completed |
| Tests follow the [best practice for testing][testing] | Completed |
| Changelog updated [in the unreleased section][changelog] including API breaking changes | Completed |
| Assign PR to reviewer | Completed |
All checks have passed (except task-list-completed) |
Completed |
| Commits are properly organized and messages are according to the guideline | Completed |
| Unit tests have been written for new behavior | Completed |
| Public API is documented | Completed |
| PR title describes the changes | Completed |
| All open points are addressed and tracked via issues | Incomplete |
Loading