Remove Unused Options #4478
Merged
Remove Unused Options #4478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this will break downstream project OpenJ9 until the cleanup in the below issue is merged. eclipse-openj9/openj9#7476 |
If this PR is not ready to merge then please mark it WIP. |
TR_EnableLargePages and TR_EnableLargeCodePages are not being used anywhere. They might be remnants of removed code. Signed-off-by: AlenBadel <[email protected]>
|
I've created a new PR which just cleans up this option within OpenJ9. Once that PR is merged, we can merge this. |
|
FYI @gita-omr |
|
@0xdaryl The downstream PR was merged, this can be reviewed and safely merged. |
|
@genie-omr build all |
0xdaryl
approved these changes
Oct 23, 2019
|
@nbhuiyan fyi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TR_EnableLargePages and TR_EnableLargeCodePages are not being used anywhere. They might be remnants of removed code.
Signed-off-by: AlenBadel [email protected]