Remove Unused Options #7563
Merged
Remove Unused Options #7563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TR_EnableLargePages and TR_EnableLargeCodePages are not being used anywhere. They might be remnants of removed code. Also realigned code spacing. Signed-off-by: AlenBadel <[email protected]>
|
Removing the option within OMR: eclipse-omr/omr#4478 |
|
Jenkins test sanity aix,plinux jdk8 |
gita-omr
reviewed
Oct 23, 2019
|
@gita-omr Since you're having trouble looking at the commit, I'll highlight and comment what was changed/moved. |
AlenBadel
commented
Oct 23, 2019
AlenBadel
commented
Oct 23, 2019
AlenBadel
commented
Oct 23, 2019
AlenBadel
commented
Oct 23, 2019
|
@AlenBadel thanks a lot for your help! I used another diff program and showed the changes clearly. |
gita-omr
approved these changes
Oct 23, 2019
|
@gita-omr All passed. It can be merged unless anyone else wants to chime in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TR_EnableLargePages and TR_EnableLargeCodePages are not being used anywhere. They might be remnants of removed code.
Also realigned code spacing.
Signed-off-by: AlenBadel [email protected]