INACTIVE: ZOS Xlp Codecache and ObjectHeap Changes #412

AlenBadel · 2019-10-24T18:33:38Z

Z/OS now supports the same command line argument format as other architectures for both -Xlp:codecache, and -Xlp:objectheap.

The behaviour is slightly different with the objectheap, where pagrable large files are always preferred over nonpageable when [non]pageable is not specified.

Signed-off-by: AlenBadel [email protected]

Z/OS now supports the same command line argument format as other architectures for both -Xlp:codecache, and -Xlp:objectheap. The behaviour is slightly different with the objectheap, where pagrable large files are always preferred over nonpageable when [non]pageable is not specified. Signed-off-by: AlenBadel <[email protected]>

AlenBadel · 2019-10-24T18:34:28Z

Related OpenJ9 PR
eclipse-openj9/openj9#7585

See Doc Issue
#445

pshipton · 2019-10-24T18:55:52Z

docs/xlpcodecache.md

@@ -32,14 +32,10 @@ To find out the large page sizes available and the current setting, use the `-ve

 ## Syntax

-AIX&reg;, Linux&reg;, macOS&reg;, and Windows&trade;:
+AIX&reg;, Linux&reg;, macOS&reg;, Windows&trade; and Z/OS&reg;:


This is all platforms now, so we don't need to give a platform list.

pshipton · 2019-10-24T18:58:51Z

docs/xlpcodecache.md

@@ -67,7 +63,7 @@ See [Using -X command-line options](x_jvm_commands.md) for more information abou

 : 1 MB pageable pages, when available, are the default size for the code cache.

-    The `-Xlp:codecache:pagesize=<size>,pageable` option supports only a large page size of 1 MB pageable large pages. The use of 1 MB pageable large pages for the JIT code cache can improve the runtime performance of some Java&trade; applications. A page size of 4 KB can also be used.
+    The `-Xlp:codecache:pagesize=<size>` option supports only a large page size of 1 MB pageable large pages. The use of 1 MB pageable large pages for the JIT code cache can improve the runtime performance of some Java&trade; applications. A page size of 4 KB can also be used.


Both variants should be explicit, i.e. The -Xlp:codecache:pagesize=<size> and -Xlp:codecache:pagesize=<size>,pageable options ...

pshipton · 2019-10-24T18:59:23Z

docs/xlpcodecache.md


        -Xlp:codecache:pagesize=<size>

-z/OS&reg;:
-
-        -Xlp:codecache:pagesize=<size>,pageable


This still needs to be a valid option on z/OS, and shouldn't be removed from the docs.

pshipton · 2019-10-24T18:59:50Z

docs/xlpobjectheap.md

@@ -31,14 +31,10 @@ To find out the large page sizes available and the current setting, use the `-ve

 ## Syntax

-AIX&reg;, Linux&reg;, macOS&reg;, and Windows&trade;:
+AIX&reg;, Linux&reg;, macOS&reg;, Windows&trade; and Z/OS&reg;:


This is all platforms now, so we don't need to give a platform list.

pshipton · 2019-10-24T19:00:00Z

docs/xlpobjectheap.md


        -Xlp:objectheap:pagesize=<size>[,strict|warn]

-z/OS&reg;:
-
-        -Xlp:objectheap:pagesize=<size>[,strict|warn][,pageable|nonpageable]


This still needs to be a valid option on z/OS, and shouldn't be removed from the docs.

I note this option specification is incorrect until eclipse-openj9/openj9#7585 is merged, as pageable|nonpageable is not optional

pshipton · 2019-10-24T19:00:31Z

docs/xlpobjectheap.md

@@ -61,6 +57,8 @@ See [Using -X command-line options](x_jvm_commands.md) for more information abou

 : On macOS, the default page size is 4 KB.

+: On Z/OS&reg If both 1M pageable, and nonpageable large pages are available then 1M pageable large pages will be used by default if [non]pageable is not specified.


When the pageable|nonpageable option isn't specified ...

doveye · 2019-10-25T11:37:10Z

There doesn't seem to be a corresponding doc issue for this PR. Please can you create one - updates should be committed against that. The content team can then offer help. For example:

The What's New topic (https://eclipse.github.io/openj9-docs/version0.18/) also needs updating to advise customers of the change
For -Xlp:codecache, it sounds like we are introducing another way for z/OS customers to do the same thing, ie:
-Xlp:codecache:pagesize=<size>==-Xlp:codecache:pagesize=<size>,pageable
If so, we should mention the old option only to say it is still recognised. Will it be deprecated? (If support is added for nonpageable in the future, pageable|nonpageable can be treated as a new suboption?) In the Default Values section, you could omit mentioning either option since the behaviour is the same, but I think the entry needs clarifying anyway as it's currently quite confusing. It says

1 MB pageable pages, when available, are the default size for the code cache.

and also

The ... option supports only a large page size of 1 MB pageable large pages.

Both sentences could be replaced with "The default size for the code cache is 1 MB pageable pages. No other large page sizes are supported."

For -Xlp:objectheap, the docs already say that pageable|nonpageable is optional? The pageable|nonpageable section could be modified to say something like:

On z/OS systems, defines the type of memory to allocate for the Java object heap, if you want to override the default value.

Supported pageable sizes: 1 MB and 4 KB.
Supported nonpageable sizes: 2 GB and 1 MB.

SueChaplain · 2019-10-28T10:34:11Z

@AlenBadel - all docs changes require an issue to be opened for tracking and historical purposes. Please follow this link: https://github.com/eclipse/openj9-docs/issues/new?template=new-documentation-change.md

SueChaplain · 2019-11-26T10:15:39Z

@AlenBadel - all docs changes require an issue to be opened for tracking and historical purposes. Please follow this link: https://github.com/eclipse/openj9-docs/issues/new?template=new-documentation-change.md

pmhayward · 2019-11-26T16:17:44Z

@AlenBadel ... Hi Alen, would be grateful if you'd create a doc issue for this work, outlining what was required - so that we can track it with other 0.18.0 changes. Then we can get this finished off and merged.
Many thanks, Peter

AlenBadel · 2019-12-03T15:46:42Z

@pmhayward My apologies, I've added the issue.

#445

pmhayward · 2019-12-03T16:14:06Z

@AlenBadel ... Many thanks

pmhayward · 2019-12-03T16:31:18Z

@AlenBadel ... Alen, just realised that the commit you made a short while ago wasn't signed off. Therefore Eclipse is currently rejecting the PR. If you open the "Details" link under "All checks have failed ", it gives more details and something about how to fix it. Thanks, Peter

AlenBadel · 2019-12-03T18:41:28Z

@pmhayward I'm currently working on addressing all the comments given. This PR is dependant on eclipse-openj9/openj9#7585, so it can't be merged until that PR is accepted.

pmhayward · 2020-07-16T11:34:24Z

@AlenBadel I'm assuming that as the openj9 PR is still open, this docs PR should not currently be merged; please confirm! Are these changes still likely to happen at some point? Thanks!

SueChaplain · 2021-04-21T06:48:58Z

I propose to close this PR as it is very old with respect to the current code base. If these changes are still planned, please rebase and raise a new PR.

SueChaplain · 2021-04-29T15:44:50Z

Closing. Commented in #445 to determine whether a future PR is expected or whether we can close the issue.

AlenBadel mentioned this pull request Oct 24, 2019

ZOS Use Default Large Page Type Within Objectheap and Codecache eclipse-openj9/openj9#7585

Open

pshipton reviewed Oct 24, 2019

View reviewed changes

AlenBadel mentioned this pull request Dec 3, 2019

ZOS Xlp Codecache and ObjectHeap Changes #445

Open

Remove Inclusive List

3d289a0

SueChaplain changed the title ~~ZOS Xlp Codecache and ObjectHeap Changes~~ INACTIVE: ZOS Xlp Codecache and ObjectHeap Changes Apr 29, 2021

SueChaplain closed this Apr 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

INACTIVE: ZOS Xlp Codecache and ObjectHeap Changes #412

INACTIVE: ZOS Xlp Codecache and ObjectHeap Changes #412

AlenBadel commented Oct 24, 2019 •

edited

Loading

AlenBadel commented Oct 24, 2019 •

edited

Loading

pshipton Oct 24, 2019

pshipton Oct 24, 2019

pshipton Oct 24, 2019

pshipton Oct 24, 2019

pshipton Oct 24, 2019

pshipton Oct 24, 2019 •

edited

Loading

pshipton Oct 24, 2019

doveye commented Oct 25, 2019

SueChaplain commented Oct 28, 2019

SueChaplain commented Nov 26, 2019

pmhayward commented Nov 26, 2019

AlenBadel commented Dec 3, 2019

pmhayward commented Dec 3, 2019

pmhayward commented Dec 3, 2019

AlenBadel commented Dec 3, 2019

pmhayward commented Jul 16, 2020

SueChaplain commented Apr 21, 2021

SueChaplain commented Apr 29, 2021

		@@ -61,6 +57,8 @@ See [Using -X command-line options](x_jvm_commands.md) for more information abou

		: On macOS, the default page size is 4 KB.

		: On Z/OS&reg If both 1M pageable, and nonpageable large pages are available then 1M pageable large pages will be used by default if [non]pageable is not specified.

INACTIVE: ZOS Xlp Codecache and ObjectHeap Changes #412

INACTIVE: ZOS Xlp Codecache and ObjectHeap Changes #412

Conversation

AlenBadel commented Oct 24, 2019 • edited Loading

AlenBadel commented Oct 24, 2019 • edited Loading

pshipton Oct 24, 2019

Choose a reason for hiding this comment

pshipton Oct 24, 2019

Choose a reason for hiding this comment

pshipton Oct 24, 2019

Choose a reason for hiding this comment

pshipton Oct 24, 2019

Choose a reason for hiding this comment

pshipton Oct 24, 2019

Choose a reason for hiding this comment

pshipton Oct 24, 2019 • edited Loading

Choose a reason for hiding this comment

pshipton Oct 24, 2019

Choose a reason for hiding this comment

doveye commented Oct 25, 2019

SueChaplain commented Oct 28, 2019

SueChaplain commented Nov 26, 2019

pmhayward commented Nov 26, 2019

AlenBadel commented Dec 3, 2019

pmhayward commented Dec 3, 2019

pmhayward commented Dec 3, 2019

AlenBadel commented Dec 3, 2019

pmhayward commented Jul 16, 2020

SueChaplain commented Apr 21, 2021

SueChaplain commented Apr 29, 2021

AlenBadel commented Oct 24, 2019 •

edited

Loading

AlenBadel commented Oct 24, 2019 •

edited

Loading

pshipton Oct 24, 2019 •

edited

Loading