Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INACTIVE: ZOS Xlp Codecache and ObjectHeap Changes #412

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions docs/xlpcodecache.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,8 @@ To find out the large page sizes available and the current setting, use the `-ve

## Syntax

AIX®, Linux®, macOS®, and Windows™:

-Xlp:codecache:pagesize=<size>

z/OS&reg;:

-Xlp:codecache:pagesize=<size>,pageable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs to be a valid option on z/OS, and shouldn't be removed from the docs.


See [Using -X command-line options](x_jvm_commands.md) for more information about the `<size>` parameter.

## Default values
Expand Down Expand Up @@ -67,7 +61,7 @@ See [Using -X command-line options](x_jvm_commands.md) for more information abou

: 1 MB pageable pages, when available, are the default size for the code cache.

The `-Xlp:codecache:pagesize=<size>,pageable` option supports only a large page size of 1 MB pageable large pages. The use of 1 MB pageable large pages for the JIT code cache can improve the runtime performance of some Java&trade; applications. A page size of 4 KB can also be used.
The `-Xlp:codecache:pagesize=<size>` option supports only a large page size of 1 MB pageable large pages. The use of 1 MB pageable large pages for the JIT code cache can improve the runtime performance of some Java&trade; applications. A page size of 4 KB can also be used.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both variants should be explicit, i.e. The -Xlp:codecache:pagesize=<size> and -Xlp:codecache:pagesize=<size>,pageable options ...


## See also

Expand Down
8 changes: 2 additions & 6 deletions docs/xlpobjectheap.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,8 @@ To find out the large page sizes available and the current setting, use the `-ve

## Syntax

AIX&reg;, Linux&reg;, macOS&reg;, and Windows&trade;:

-Xlp:objectheap:pagesize=<size>[,strict|warn]

z/OS&reg;:

-Xlp:objectheap:pagesize=<size>[,strict|warn][,pageable|nonpageable]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs to be a valid option on z/OS, and shouldn't be removed from the docs.

Copy link
Member

@pshipton pshipton Oct 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I note this option specification is incorrect until eclipse-openj9/openj9#7585 is merged, as pageable|nonpageable is not optional


See [Using -X command-line options](x_jvm_commands.md) for more information about the `<size>` parameter.

## Parameters
Expand All @@ -61,6 +55,8 @@ See [Using -X command-line options](x_jvm_commands.md) for more information abou

: On macOS, the default page size is 4 KB.

: On Z/OS&reg If both 1M pageable, and nonpageable large pages are available then 1M pageable large pages will be used by default if [non]pageable is not specified.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the pageable|nonpageable option isn't specified ...


### `strict` | `warn`

-Xlp:objectheap:strict
Expand Down