Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove remaining Ember 5 deprecation warnings #1275

Conversation

@jaredgalanis jaredgalanis force-pushed the refactor-remove-ember-data-deprecate-promise-many-array-behaviors-deprecation-2 branch from 0fc94b4 to 695a427 Compare June 28, 2024 13:30
@jaredgalanis jaredgalanis changed the base branch from refactor-remove-ember-data-deprecate-array-like-deprecation to main June 28, 2024 14:25
@jaredgalanis jaredgalanis changed the title refactor: remove ember data deprecate promise many array behaviors deprecation refactor: remove remaining Ember 5 deprecation warnings Jun 28, 2024
Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
I did not a bunch of testing locally and it looks good.

@jaredgalanis jaredgalanis merged commit 5219b46 into main Jun 28, 2024
1 check passed
@jaredgalanis jaredgalanis deleted the refactor-remove-ember-data-deprecate-promise-many-array-behaviors-deprecation-2 branch June 28, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants