-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove remaining Ember 5 deprecation warnings #1275
Merged
jaredgalanis
merged 9 commits into
main
from
refactor-remove-ember-data-deprecate-promise-many-array-behaviors-deprecation-2
Jun 28, 2024
Merged
refactor: remove remaining Ember 5 deprecation warnings #1275
jaredgalanis
merged 9 commits into
main
from
refactor-remove-ember-data-deprecate-promise-many-array-behaviors-deprecation-2
Jun 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredgalanis
force-pushed
the
refactor-remove-ember-data-deprecate-promise-many-array-behaviors-deprecation-2
branch
from
June 28, 2024 13:30
0fc94b4
to
695a427
Compare
jaredgalanis
changed the base branch from
refactor-remove-ember-data-deprecate-array-like-deprecation
to
main
June 28, 2024 14:25
jaredgalanis
changed the title
refactor: remove ember data deprecate promise many array behaviors deprecation
refactor: remove remaining Ember 5 deprecation warnings
Jun 28, 2024
This was referenced Jun 28, 2024
markpatton
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
I did not a bunch of testing locally and it looks good.
jaredgalanis
deleted the
refactor-remove-ember-data-deprecate-promise-many-array-behaviors-deprecation-2
branch
June 28, 2024 14:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one involves removing the following deprecations: