Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not load sequence number from target files anymore #1544

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Dec 31, 2024

As the sequence number is not persisted into a target file by the target editor, there is actually no point in loading it as it only can lead to inconsistent state.

As the sequence number is not persisted into a target file by the target
editor, there is actually no point in loading it as it only can lead to
inconsistent state.
Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Can you tell if existing sequenceNumber attributes will now be removed (implicitly) on the next change? If not, it would be remove them automatically so that users don't wonder about them anymore.

@laeubi
Copy link
Contributor Author

laeubi commented Dec 31, 2024

They are not touched as before like any other custom attribute.

@laeubi laeubi merged commit da880f2 into eclipse-pde:master Dec 31, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants