Images not aligned properly in Expand Bar

[ShahzaibIbrahim]

When adding image larger than the header size in expand bar, it was drawn outside of the bar on the top. This was due to wrong calculation and mixing of points and pixels.

HOW TO TEST

• Go to ExpandBarTab class and set any larger image on item

• Run the ControlExample with the following VM Arguments

-Dswt.autoScale=quarter
-Dswt.autoScale.updateOnRuntime=true

• Switch to the tab "Expand Items"
• See if the image is within the bounds of the bar/header

SCREENSHOTS

Before Fix:

After Fix:

[github-actions]

Test Results

   483 files  ±0     483 suites  ±0   8m 4s ⏱️ - 1m 29s
 4 095 tests ±0   4 085 ✅ ±0   7 💤 ±0  3 ❌ ±0 
16 173 runs  ±0  16 080 ✅ ±0  90 💤 ±0  3 ❌ ±0 

For more details on these failures, see this check.

Results for commit 377d3eb. ± Comparison against base commit d59358c.

♻️ This comment has been updated with latest results.

[fedejeanne]

The code looks quite good and it's easy to understand (just one minor nit-pick), but I tested it and found an issue.

How to reproduce

• Change the second image of org.eclipse.swt.examples.controlexample.ControlExample.imageLocations from openFolder.gif to some other image that is way bigger (e.g. 300 x 300 or more)
• Run the ControlsExample and go to the ExpandBar
• Expand the upper section: "What is your favorite button?"

The text of the second section (1) and its image (2) are still in the same place as before but they should be moved a bit lower.

I can't reproduce this error on master, I mean the text is still too low but it will be moved accordingly when expanding/collapsing the first section:

[fedejeanne]

Thank you for fixing the issue, @ShahzaibIbrahim ! I tested again and I only have 2 comments about changes that need to be reverted.

I would also change the first line of the commit text to Properly align big images in ExpandBar.

Once that is fixed, the PR is good to go on my account.

The bug I discovered has been fixed. The rest is not a show stopper

[HeikoKlare]

The recent changes have properly addressed my comment. In my opinion, the selected margin looks good:

And adding this margin does also not change exististing layout (i.e., does not unnecessarily introduce additional margins), at least when taking a look at the ControlExample (left is existing, right is with this PR):

I have just one remaining comment.

[HeikoKlare]

Test failures unrelated and documented: #1564