Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies workflow): remove obsolete step and check #466

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

saadanzari
Copy link
Member

@saadanzari saadanzari commented Mar 4, 2025

Description

Update obsolete logic in Dependencies.yaml for "Check if dependencies were changed".

Why

After the improvement done during of #431, It is noticed that the check if the dependencies file was changed is obsolete. The relevant steps affected by this constraint should be executed every time the workflow is triggered.

Additional Information
Relates to TRG 7.03

- **Dependencies Workflow**:
  - removed obsolete step and check [#466](https://github.com/eclipse-tractusx/portal-assets/pull/466)

Issue

#463

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@saadanzari saadanzari requested a review from evegufy March 4, 2025 15:46
@saadanzari saadanzari self-assigned this Mar 4, 2025
@saadanzari saadanzari added the enhancement New feature or request label Mar 4, 2025
@saadanzari saadanzari added this to the Release 25.06 milestone Mar 4, 2025
@evegufy evegufy changed the title chore(dependencies workflow): refactor dependency conflict resolution logic chore(dependencies workflow): remove obsolete step and check Mar 5, 2025
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while reviewing, I noticed that you removed the exit 1 at the last step and as a result that we still need the step after all, just not anymore at the Check for restricted dependencies as that step should always get executed.
Could you please move the step after the Check for restricted dependencies and just remove it from that one step? And adjust the PR title and description accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: IN PROGRESS
Development

Successfully merging this pull request may close these issues.

2 participants