-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Selected Values Not Saved or Reset to Default in SelectList Component #257
fix: Selected Values Not Saved or Reset to Default in SelectList Component #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update changelog.md file too
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variable naming
|
||
onChangeItem(reason) | ||
onChange={(_event, _nextValue) => { | ||
handleChange(_nextValue) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please only use names starting with underscore if the variable is not used
_nextValue
change to nextValue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code updated
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm now
Hey @oyo, @lavanya-bmw |
Description
Why
This change is necessary to address a critical issue where the
SelectList
component does not save the selected values upon form submission, or resets them to the default values. This issue affects the data integrity and user experience, as users expect their selections to be retained and accurately reflected in the submitted data.Dependencies
There are no additional dependencies required for this change. The fix involves modifying the existing
SelectList
component to ensure proper handling of the selected values.Implementing this change will enhance the reliability and functionality of the
SelectList
component, ensuring that it meets user expectations and maintains accurate data handling across the application.Issue
Checklist
Please delete options that are not relevant.