Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

chore: add alpine as allowed base image #51

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

FaGru3n
Copy link
Contributor

@FaGru3n FaGru3n commented Oct 6, 2023

Description

  • add 'alpine' as allowed base-image

updates eclipse-tractusx/sig-infra#259

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link
Contributor

@almadigabor almadigabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FaGru3n FaGru3n merged commit 673a3be into main Oct 10, 2023
@carslen carslen deleted the chore/add-apline-as-allowed-base-image branch October 10, 2023 09:30
@SebastianBezold
Copy link
Contributor

I think it is ok to merge it, but I'm missing some examples in our unit-tests.
The check is currently just doing a lazy contains. This would allow too many images in my opinion.
So what do we want to allow as base image here? is it plain alpine, or is it every image, that is based on alpine like a postgres alpine image for example?

We should add proper unit-tests with allowed and unallowed examples and enhance the isAllowedBaseImage function

/ping @FaGru3n @almadigabor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants