Configure scouting/*/autoconnect/* with a sequence
#1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzypixelz
added
enhancement
fuzzypixelz
changed the title
scouting/*/autoconnect with a sequencescouting/*/autoconnect/* with a sequence
Mallets
reviewed
Jul 16, 2024
fuzzypixelz
force-pushed
the
config-autoconnect-with-sequence
branch
from
08b6213 to
efc7e08
Compare
This attribute makes it hard to debug certain errors and was only present on autoconnect fields.
Mallets
approved these changes
Jul 19, 2024
tomkimsour
added a commit
to tomkimsour/zenoh-plugin-ros2dds
that referenced
this pull request
Oct 14, 2024
gabrik
pushed a commit
to eclipse-zenoh/zenoh-plugin-ros2dds
that referenced
this pull request
Oct 14, 2024
Related to eclipse-zenoh/zenoh#1224 and #295
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is easier to read and less error prone. JSON already has a construct for sequences, we should use it.