Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Querier #1591

Merged
merged 33 commits into from
Dec 2, 2024
Merged

add Querier #1591

merged 33 commits into from
Dec 2, 2024

Conversation

DenisBiryukov91
Copy link
Contributor

@DenisBiryukov91 DenisBiryukov91 commented Nov 12, 2024 •
edited
Loading

Add Querier;
Adapt MatchingStatus and MatchingListener to work with Querier;
Closes #1605;

@github-actions GitHub Actions
Copy link

PR missing one of the required labels: {'enhancement', 'dependencies', 'new feature', 'internal', 'documentation', 'breaking-change', 'bug'}

@DenisBiryukov91 DenisBiryukov91 added the new feature Something new is needed label Nov 12, 2024
@DenisBiryukov91 DenisBiryukov91 force-pushed the querier branch 2 times, most recently from 59f74fd to 71d83cb Compare November 13, 2024 10:29
@DenisBiryukov91 DenisBiryukov91 marked this pull request as ready for review November 14, 2024 09:03
@DenisBiryukov91 DenisBiryukov91 force-pushed the querier branch 3 times, most recently from a67ea5b to 8e2659b Compare November 14, 2024 13:58
@DenisBiryukov91 DenisBiryukov91 force-pushed the querier branch 2 times, most recently from e5f9624 to ffc7f5e Compare November 18, 2024 18:39
@DenisBiryukov91
add matching listener to z_pub example;
4a0f968 
add flag to enable/disable matching listener in the z_pub and z_querier examples;
@Mallets
Copy link
Member

Mallets commented Nov 26, 2024

The API LGTM. Could you also add a test for the declare_querier and matching_status?

OlivierHecart
OlivierHecart reviewed Nov 26, 2024
View reviewed changes
commons/zenoh-config/src/lib.rs Outdated Show resolved Hide resolved
examples/examples/z_querier.rs Outdated Show resolved Hide resolved
zenoh/src/api/publisher.rs Outdated Show resolved Hide resolved
zenoh/src/api/builders/matching_listener.rs Outdated Show resolved Hide resolved
zenoh/src/api/key_expr.rs Show resolved Hide resolved
examples/examples/z_querier.rs Show resolved Hide resolved
@DenisBiryukov91 DenisBiryukov91 mentioned this pull request Nov 27, 2024
Open
@DenisBiryukov91 DenisBiryukov91 mentioned this pull request Nov 29, 2024
Merged
@milyin milyin mentioned this pull request Dec 2, 2024
Open
7 tasks
milyin
milyin requested changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@milyin milyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The only change needed: Querier should be released under "unstable" feature for the first time, it's too risky to release it to stable API immediately

@DenisBiryukov91 DenisBiryukov91 mentioned this pull request Dec 2, 2024
Merged
@DenisBiryukov91 DenisBiryukov91 force-pushed the querier branch 4 times, most recently from 2f1900a to 1ba9acc Compare December 2, 2024 16:37
@milyin milyin merged commit 549bc7b into eclipse-zenoh:main Dec 2, 2024
13 checks passed
@DariusIMP DariusIMP mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

@OlivierHecart OlivierHecart OlivierHecart left review comments

@milyin milyin milyin approved these changes

Assignees
No one assigned
Labels
new feature Something new is needed
Projects
None yet
Milestone
No milestone
4 participants
@DenisBiryukov91 @Mallets @OlivierHecart @milyin