Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use reusable workflows from pyTooling/Actions #31

Merged
merged 24 commits into from
Dec 1, 2021
Merged

Conversation

umarcor
Copy link
Member

@umarcor umarcor commented Nov 27, 2021

In this PR, the CI Pipeline is reworked in order to use reusable workflows from pyTooling/Actions (see pyTooling/Actions#1).

Each job is replaced with a call to a reusable workflow.

As explained in VHDL/pyVHDLModel#36, the logic for dealing with global parameters is changed.

MPORTANT: reusable workflows must be used through an absolute name and specifying a version (see actions/runner#1493). Therefore, this PR will be kept as a draft, because s/@dev/@main/ is required in Pipeline.yml before merging.

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2021

Codecov Report

Merging #31 (e7778f9) into dev (557d582) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #31   +/-   ##
=======================================
  Coverage   82.83%   82.83%           
=======================================
  Files           9        9           
  Lines        1468     1468           
  Branches      236      236           
=======================================
  Hits         1216     1216           
  Misses        192      192           
  Partials       60       60           
Flag Coverage Δ
unittests 82.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 557d582...e7778f9. Read the comment docs.

@umarcor umarcor force-pushed the ci-pyactions branch 2 times, most recently from b0eea54 to 1419e65 Compare November 29, 2021 02:45
@umarcor umarcor closed this Nov 29, 2021
@umarcor umarcor deleted the ci-pyactions branch November 29, 2021 12:19
@umarcor umarcor restored the ci-pyactions branch November 29, 2021 12:27
@umarcor umarcor reopened this Nov 29, 2021
@umarcor umarcor force-pushed the ci-pyactions branch 3 times, most recently from c3f3329 to 1146f38 Compare November 29, 2021 23:09
@Paebbels
Copy link
Member

pyTooling/Actions#1 is now merged. Do you want to adjust the branch name?

I suggest to use a tag like v0 (while still testing) and then later v1.
What do you think?

@umarcor
Copy link
Member Author

umarcor commented Nov 30, 2021

I suggest to use a tag like v0 (while still testing) and then later v1. What do you think?

See pyTooling/Actions#5.

@umarcor
Copy link
Member Author

umarcor commented Nov 30, 2021

Ref v0 is available in pyTooling/Actions now. I updated this PR accordingly.

I think this is ready to review and merge.

@umarcor umarcor marked this pull request as ready for review November 30, 2021 15:33
.github/workflows/Pipeline.yml Show resolved Hide resolved
.github/workflows/Pipeline.yml Show resolved Hide resolved
.github/workflows/Pipeline.yml Outdated Show resolved Hide resolved
@Paebbels Paebbels merged commit e2f0284 into dev Dec 1, 2021
@Paebbels Paebbels deleted the ci-pyactions branch December 1, 2021 06:32
@umarcor umarcor added the Enhancement New feature or request label Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants