-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: write infrastructure to new state file #2321
Conversation
✅ Deploy Preview for constellation-docs canceled.
|
3336fdf
to
0dee6aa
Compare
Coverage report
|
0dee6aa
to
61747c3
Compare
2355be8
to
d4aa307
Compare
LGTM. Would just like to discuss that one point. |
Before merging this: what is the plan to ensure that the migration from the idfile to the statefile happens within 1 release cycle? How do we migrate? |
The idFile is only removed in the last step (see user stories in Azure). So the code is not broken at any point. |
Good to merge from my side. |
cd3a85b
to
d206a59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc comments in this file need some work, but should probably be handled in AB#3426
5ce0d30
to
e603c2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: 3u13r <[email protected]>
Co-authored-by: 3u13r <[email protected]>
Context
This is the first implementation part of the new constellation state (#2281).
Proposed change(s)
create
constellation-state.yaml
with version v1 after terraform applyupgrade
constellation-state.yaml
with version v1 after terraform applyRelated issue
Checklist