-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: allow jobs to install tools from pinned nixpkgs #2605
Conversation
✅ Deploy Preview for constellation-docs canceled.
|
03deb2c
to
79de41b
Compare
@miampf FYI. This enables you to install tools like zip by specifying:
|
This would require us to add the tools in the top-level workflow where the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my above comment, changes LGTM
Agreed. This is not ideal but probably a good enough approximation. Ideally, any bash scripts used in the CI would be built and run using nix directly and would explicitly list direct dependencies. |
2181361
to
2a94368
Compare
be78dbb
to
102bbb8
Compare
878275d
to
f419cb2
Compare
Context
We often need additional tools in GitHub Actions Workflow jobs. This extension to the
setup_bazel_nix
action adds a new parameternixTools
which (if provided) will install a list of tools for the duration of the job and add their store paths to theGITHUB_PATH
env.Proposed change(s)
Additional info
Checklist