-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: encrypt artifacts #2567
ci: encrypt artifacts #2567
Conversation
✅ Deploy Preview for constellation-docs canceled.
|
Removed the security-fix label as this is rather a defensive security measure on our side and since it interferes with the no-changelog label in the changelog generation process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One general thing: If making as many commits is part of your standard workflow, awesome! If you do this because you think we expect it. No. Feel free to do less commits, don't feel urged by the "guidelines" saying that you should push your work regularly. This is really regular. However, I really don't wan't you to change it if it's part of your default workflow. Just don't feel urged to do that by us :D
4f03a7b
to
dc86d93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look really good to me already other than that :)
790625d
to
0c68fcf
Compare
f1d79c9
to
b1536b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for the test removal that Paul mentioned.
b1536b9
to
1371170
Compare
2489a80
to
a088b9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think this can be merged 🚀 |
a088b9b
to
438e710
Compare
Context
Currently, any artifacts uploaded by the CI are unencrypted which can be insecure (e.g. for logs).
Proposed change(s)
.github/actions/artifact_upload
.github/actions/artifact_download
actions/upload-artifact
/actions/download-artifact
with their respective wrappersChecklist