-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update GCP service accounts for CI #2629
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
daniel-weisse
force-pushed
the
ref/ci/move-e2e-to-new-project
branch
from
November 22, 2023 15:23
0e26016
to
08015f5
Compare
self-managed resources seem to not be cleaned up properly, but this should unrelated to this PR |
daniel-weisse
changed the title
ci: use different GCP project
ci: use different GCP project for running e2e tests
Nov 23, 2023
daniel-weisse
force-pushed
the
ref/ci/move-e2e-to-new-project
branch
from
November 23, 2023 12:12
829f170
to
292ee66
Compare
daniel-weisse
changed the title
ci: use different GCP project for running e2e tests
ci: update GCP service accounts for CI
Nov 23, 2023
daniel-weisse
force-pushed
the
ref/ci/move-e2e-to-new-project
branch
from
November 24, 2023 10:46
2d10b0c
to
75cf047
Compare
malt3
approved these changes
Nov 27, 2023
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
daniel-weisse
force-pushed
the
ref/ci/move-e2e-to-new-project
branch
from
November 27, 2023 11:20
75cf047
to
8c9694b
Compare
Coverage report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want to use a separate project for running e2e tests on GCP, as well as restrict the service accounts used for said e2e tests and image builds.
Proposed change(s)
gcpInClusterServiceAccountKey
account from.github/actions/e2e_test/action.yml
constellation-cos-builder
)image-deleter
to delete images built on feature/testing branches after they were mergedimage-uploader
to upload images built on feature/testing branches to GCPAdditional info
image-deleter
service account and the versionsapi CLI