Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update GCP service accounts for CI #2629

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

daniel-weisse
Copy link
Member

@daniel-weisse daniel-weisse commented Nov 22, 2023

Context

We want to use a separate project for running e2e tests on GCP, as well as restrict the service accounts used for said e2e tests and image builds.

Proposed change(s)

  • Update service accounts used for infrastructure creation and IAM creation
  • Remove unused gcpInClusterServiceAccountKey account from .github/actions/e2e_test/action.yml
    • This secret should also be deleted from this repo
  • Update project used for deploying e2e tests
    • We currently have this saved as a secret, making updating it rather difficult without breaking things
    • For now, I just hard coded the new project. We can either keep it like this, or change back to using a secret and update the secret in this repo before merging
  • Update the service account used to build images (previously constellation-cos-builder)
    • image-deleter to delete images built on feature/testing branches after they were merged
    • image-uploader to upload images built on feature/testing branches to GCP
  • Update dev-docs

Additional info

@daniel-weisse daniel-weisse added the no changelog Change won't be listed in release changelog label Nov 22, 2023
Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit 8c9694b
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/65647b98c815a6000859eb96
😎 Deploy Preview https://deploy-preview-2629--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@daniel-weisse daniel-weisse force-pushed the ref/ci/move-e2e-to-new-project branch from 0e26016 to 08015f5 Compare November 22, 2023 15:23
@daniel-weisse daniel-weisse marked this pull request as ready for review November 23, 2023 09:51
@daniel-weisse
Copy link
Member Author

self-managed resources seem to not be cleaned up properly, but this should unrelated to this PR
Will investigate

@daniel-weisse daniel-weisse requested a review from malt3 November 23, 2023 09:52
@daniel-weisse daniel-weisse changed the title ci: use different GCP project ci: use different GCP project for running e2e tests Nov 23, 2023
@daniel-weisse daniel-weisse force-pushed the ref/ci/move-e2e-to-new-project branch from 829f170 to 292ee66 Compare November 23, 2023 12:12
@daniel-weisse daniel-weisse changed the title ci: use different GCP project for running e2e tests ci: update GCP service accounts for CI Nov 23, 2023
@daniel-weisse daniel-weisse force-pushed the ref/ci/move-e2e-to-new-project branch from 2d10b0c to 75cf047 Compare November 24, 2023 10:46
@daniel-weisse daniel-weisse force-pushed the ref/ci/move-e2e-to-new-project branch from 75cf047 to 8c9694b Compare November 27, 2023 11:20
Copy link
Contributor

Coverage report

Package Old New Trend
image/upload/internal/cmd [no test files] [no test files] 🚧

@daniel-weisse daniel-weisse merged commit 97aea98 into main Nov 27, 2023
9 checks passed
@daniel-weisse daniel-weisse deleted the ref/ci/move-e2e-to-new-project branch November 27, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants