Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform-provider: init provider scaffolding #2632

Merged
merged 12 commits into from
Nov 24, 2023
Merged

terraform-provider: init provider scaffolding #2632

merged 12 commits into from
Nov 24, 2023

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Nov 22, 2023 •
edited by azure-boards bot
Loading

Context

We want to add the Terraform provider code to the Constellation repository to start building the Terraform provider.

Proposed change(s)

  • Initiate the Terraform Provider Scaffolding in our repository, and populate the provider default values with Constellation-specific values, which are subject to change in the future if required. Explicitly do not change the default data sources and resources in this PR.
  • Add a build process for the provider and it's documentation, incorporating the targets in the devbuild convenience target. Test and Release CI is explicitly not done within this PR.
  • Add basic developer documentation on how the provider will be used.

Additional info

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@msanft msanft requested review from elchead and daniel-weisse and removed request for katexochen November 22, 2023 14:16
@netlify Netlify
Copy link

netlify bot commented Nov 22, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit a652d6a
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/655f04249c2bfc00099159e4

@msanft msanft force-pushed the feat/terraform/init-provider-scaffolding branch from be43c6d to 4760ae4 Compare November 22, 2023 14:20
elchead
elchead reviewed Nov 22, 2023
View reviewed changes
bazel/ci/terraform.sh.in Outdated Show resolved Hide resolved
elchead
elchead approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@elchead elchead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't look into the bazel changes but the rest lgtm.

dev-docs/workflows/terraform-provider.md Show resolved Hide resolved
@elchead elchead added the no changelog Change won't be listed in release changelog label Nov 22, 2023
@elchead elchead added this to the v2.14.0 milestone Nov 22, 2023
@msanft msanft added feature This introduces new functionality and removed no changelog Change won't be listed in release changelog labels Nov 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Package Old New Trend
terraform-provider-constellation 0.00% [no test files] 🚨
terraform-provider-constellation/internal/provider 0.00% 3.20% 🆕

@msanft msanft mentioned this pull request Nov 23, 2023
Merged
4 tasks
@msanft msanft merged commit 9a62657 into main Nov 24, 2023
9 checks passed
@msanft msanft deleted the feat/terraform/init-provider-scaffolding branch November 24, 2023 14:58
@burgerdev burgerdev added no changelog Change won't be listed in release changelog and removed feature This introduces new functionality labels Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-weisse daniel-weisse daniel-weisse approved these changes

@elchead elchead elchead approved these changes

@malt3 malt3 Awaiting requested review from malt3

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@msanft @elchead @daniel-weisse @burgerdev