bootstrapper: only err if no control plane IPs available #3496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we errored out of the entire join if retrieval of either LB IP or control plane public IP failed. This resulted in the entire "use either IP" logic not working as intended. This now makes it log a warning only if the IP retrievals fail, and only errors out of the join if no IP can be found at all.
✅ Deploy Preview for constellation-docs canceled.
|
burgerdev
approved these changes
Nov 26, 2024
| return nil, nil, fmt.Errorf("failed to get load balancer endpoint: %w", err) | ||
| c.log.Warn("Failed to get load balancer endpoint", "err", err) |
There was a problem hiding this comment.
As far as I understand we could leave this block unchanged, because joining via node IP does not work anyway due to node-to-node strict mode. Otoh, this way it's nicely symmetric.
daniel-weisse
approved these changes
Nov 26, 2024
Coverage report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Previously we errored out of the entire join if retrieval of either LB IP or control plane public IP failed. This resulted in the entire "use either IP" logic not working as intended.
This also fixes the problem encountered by STACKIT folks, where public IP retrieval fails and thus no nodes can join the cluster.
Proposed change(s)
Checklist