Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrapper: only err if no control plane IPs available #3496

Merged
merged 1 commit into from
Nov 26, 2024
Merged

bootstrapper: only err if no control plane IPs available #3496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bootstrapper/internal/joinclient/joinclient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,13 +173,13 @@ func (c *JoinClient) tryJoinWithAvailableServices() (ticket *joinproto.IssueJoin

endpoint, _, err := c.metadataAPI.GetLoadBalancerEndpoint(ctx)
if err != nil {
return nil, nil, fmt.Errorf("failed to get load balancer endpoint: %w", err)
c.log.Warn("Failed to get load balancer endpoint", "err", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand we could leave this block unchanged, because joining via node IP does not work anyway due to node-to-node strict mode. Otoh, this way it's nicely symmetric.

}
endpoints = append(endpoints, endpoint)

ips, err := c.getControlPlaneIPs(ctx)
if err != nil {
return nil, nil, fmt.Errorf("failed to get control plane IPs: %w", err)
c.log.Warn("Failed to get control plane IPs", "err", err)
}
endpoints = append(endpoints, ips...)

Expand Down
Loading