Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attestation: log Validate errors #1027

Merged
merged 1 commit into from
Nov 26, 2024
Merged

attestation: log Validate errors #1027

merged 1 commit into from
Nov 26, 2024

Conversation

burgerdev
Copy link
Contributor

Validation errors are currently swallowed somewhere in the TLS stack. Debugging e.g. this would be easier if we saw which step failed and why.

This commit also converts the hex-encoded reports in logs to JSON, in an attempt to make them easier to work with.

@burgerdev burgerdev added the no changelog PRs not listed in the release notes label Nov 25, 2024
@burgerdev burgerdev force-pushed the burgerdev/validation-logs branch from 10e7726 to 420a039 Compare November 25, 2024 07:18
@burgerdev burgerdev requested a review from 3u13r November 25, 2024 09:02
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/attestation/tdx/validator.go Outdated Show resolved Hide resolved
@burgerdev burgerdev force-pushed the burgerdev/validation-logs branch from 420a039 to b8edc4f Compare November 26, 2024 07:06
@burgerdev burgerdev merged commit ad5020f into main Nov 26, 2024
10 checks passed
@burgerdev burgerdev deleted the burgerdev/validation-logs branch November 26, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants